Coder Social home page Coder Social logo

Comments (13)

Bost avatar Bost commented on June 8, 2024 1

A comment on the timestamp, can you add additional timestamp

Just want put some extra stress on the word add as in "accretion". Whatever additional timestamp you decide to provide do not change the existing one. IOW do not introduce any format breaking changes. Never. Thanks.

from covid19-api.

nat236919 avatar nat236919 commented on June 8, 2024 1

You're welcome, but I think you are looking at @dawenx's dashboard :)

Sorry, that was my bad, sir. I've just realised I need to rest, lol.

from covid19-api.

dawenx avatar dawenx commented on June 8, 2024

Agree with Bost's comment on the repo: really a nice job and appreciated!

A comment on the timestamp, can you add additional timestamp in another format, maybe a format the same as "Last Update" ? For example, "2020-02-09 23:33:02" in https://github.com/CSSEGISandData/2019-nCoV/blob/master/daily_case_updates/02-09-2020_2320.csv

from covid19-api.

nat236919 avatar nat236919 commented on June 8, 2024

@Bost @dawenx Thank you for your comments. I will look into it soon.

from covid19-api.

dawenx avatar dawenx commented on June 8, 2024

thanks @nat236919 check out my application if you have a few minutes, i'm using JHU's data as well: https://nssac.github.io/dashboard/

from covid19-api.

cbunicef avatar cbunicef commented on June 8, 2024

I noticed that the timestamp is no longer included on the current endpoint. I would strongly suggest re-adding it, and adding it to the other endpoints as well. It's valuable because it allows us to confirm the actual date the data was collected - if your service has an error in refreshing data in the future, it would be clear by the timestamp that the data is no longer current.

Adding that it's also best practice to not make significant changes to existing endpoints, particularly removing information from them. Applications that use the "ts" object which was previously available may now be broken.

EDIT: Looking through the code I see that the timestamp is derived from the server time. You might re-add that to restore compatibility, but it would be more useful if there were a time field derived from the dataset, so that it can be confirmed what time the original data was published.

from covid19-api.

nat236919 avatar nat236919 commented on June 8, 2024

@cbunicef Thank you for your comment. I have added both datetime and timestamp to the data. FYI, I am not quite sure what Time Zone they use.

from covid19-api.

cbunicef avatar cbunicef commented on June 8, 2024

Thanks @nat236919. Looks like they are using GMT for data published after Feb 1:

https://github.com/CSSEGISandData/COVID-19/tree/master/daily_case_updates

from covid19-api.

nat236919 avatar nat236919 commented on June 8, 2024

@cbunicef Thank you so much

from covid19-api.

cbunicef avatar cbunicef commented on June 8, 2024

You're welcome, but I think you are looking at @dawenx's dashboard :)

from covid19-api.

nat236919 avatar nat236919 commented on June 8, 2024

thanks @nat236919 check out my application if you have a few minutes, i'm using JHU's data as well: https://nssac.github.io/dashboard/

I finally got a chance to check out your dashboard; it's awesome.
I was wondering if you could share your tech stack. I'm planning to generate a dashboard in the near future.

from covid19-api.

dawenx avatar dawenx commented on June 8, 2024

I talked to JHU’s developer yesterday, in their curated data, “last update” field: after 01/31 is UTC time, before 01/31 (including 01/31) was EDT. @nat236919

from covid19-api.

nat236919 avatar nat236919 commented on June 8, 2024

add 'timeseries' API endpoint
5fa9788

from covid19-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.