Clean up "-D" compile time macros used in pc-linux build about osal

[skliper]

Imported from trac issue 27. Created by jphickey on 2015-03-18T12:09:07, last modified: 2015-11-20T16:22:16

[skliper]

Trac comment by jphickey on 2015-04-14 12:57:48:

This changeset has been rebased to the (unapproved) 2015-04-14 baseline

This is due to a dependency on files added/changed as part of that basline. Attempting to base this change on the official 2015-02-26 OSAL is potentially possible but will result in merge conflicts when putting these back together again.

Commit [changeset:ce108a3] is ready for review

[skliper]

Trac comment by glimes on 2015-05-18 20:11:16:

Accept based on commit [changeset:8662839]

The only flag being removed that I ever saw used
was SOFTWARE_LITTLE_BIT_ORDER, and that code
could and should have been written to not need it.

If it still exists, I'll gladly provide the rewrite.

[skliper]

Trac comment by sstrege on 2015-05-19 10:53:38:

The SOFTWARE_BIG_BIT_ORDER flag is used in the cFE's ccsds.h file.

The SOFTWARE_LITTLE_BIT_ORDER flag is used in the cFE UTF and elf tool makefiles.

[skliper]

Trac comment by jphickey on 2015-05-19 11:23:50:

Replying to [comment:3 sstrege]:

The SOFTWARE_BIG_BIT_ORDER flag is used in the cFE's ccsds.h file.

The SOFTWARE_LITTLE_BIT_ORDER flag is used in the cFE UTF and elf tool makefiles.

Re: SOFTWARE_BIG_BIT_ORDER
Thanks for pointing this one out - this is a new one that wasn't there in CFE 6.3.2 which is the version that I am porting all these changes from.

It appears that the related CFE_MAKE_BIG16 macro was also added to some table definitions in the SC app.

Seems relatively easy to modify SC to not need this, though - as it is just hard-coded tables. Wouldn't it be easier to define the SC table simply as uint8's, and therefore not need any macro magic?

Re: SOFTWARE_LITTLE_BIT_ORDER
These may be left in the makefile due to cut-and-paste, but they are not serving any purpose as the code doesn't use them. In fact, these would be wrong if building UT for a big endian processor, which is IMO evidence why these //do// need to be purged out.

This change set is only currently removing these macros from the CMake build.

[skliper]

Trac comment by acudmore on 2015-06-01 14:09:56:

Approve as this applies to the CMake build.

Comment 4 looks like a good case for removing the macros in the traditional make system. But we at least have to figure out what to do with the tables.

[skliper]

Trac comment by jphickey on 2015-07-09 14:17:52:

== REBASED AND UPDATED ==

For the 2015-07-14 CCB review/discussion

• Commit [changeset:4aaaf64] contains the original modification rebased to the current OSAL development version.
• Commit [changeset:543eecb] contains an additional modification to address concerns about code out there that might still depend on {{{SOFTWARE_BIG_BIT_ORDER}}} or {{{SOFTWARE_LITTLE_BIT_ORDER}}}.

Both of these are merged into the {{{ic-2015-07-14}}} integration candidate for evaluation.

[skliper]

Trac comment by glimes on 2015-07-13 12:51:23:

Approve.

[skliper]

Trac comment by sduran on 2015-07-14 11:49:38:

Approve (compatibility macro is good)

[skliper]

Trac comment by jwilmot on 2015-07-14 12:36:37:

Recommend accept.

[skliper]

Trac comment by glimes on 2015-07-16 10:17:16:

Included in [changeset:ec67bd4 2015-07-14 development merge],
now present on Babelfish and IPAS-LIB.