Comments (11)
Imported from trac issue 27. Created by jphickey on 2015-03-18T12:09:07, last modified: 2015-11-20T16:22:16
from osal.
Trac comment by jphickey on 2015-04-14 12:57:48:
This changeset has been rebased to the (unapproved) 2015-04-14 baseline
This is due to a dependency on files added/changed as part of that basline. Attempting to base this change on the official 2015-02-26 OSAL is potentially possible but will result in merge conflicts when putting these back together again.
Commit [changeset:ce108a3] is ready for review
from osal.
Trac comment by glimes on 2015-05-18 20:11:16:
Accept based on commit [changeset:8662839]
The only flag being removed that I ever saw used
was SOFTWARE_LITTLE_BIT_ORDER, and that code
could and should have been written to not need it.
If it still exists, I'll gladly provide the rewrite.
from osal.
Trac comment by sstrege on 2015-05-19 10:53:38:
The SOFTWARE_BIG_BIT_ORDER flag is used in the cFE's ccsds.h file.
The SOFTWARE_LITTLE_BIT_ORDER flag is used in the cFE UTF and elf tool makefiles.
from osal.
Trac comment by jphickey on 2015-05-19 11:23:50:
Replying to [comment:3 sstrege]:
The SOFTWARE_BIG_BIT_ORDER flag is used in the cFE's ccsds.h file.
The SOFTWARE_LITTLE_BIT_ORDER flag is used in the cFE UTF and elf tool makefiles.
Re: SOFTWARE_BIG_BIT_ORDER
Thanks for pointing this one out - this is a new one that wasn't there in CFE 6.3.2 which is the version that I am porting all these changes from.
It appears that the related CFE_MAKE_BIG16 macro was also added to some table definitions in the SC app.
Seems relatively easy to modify SC to not need this, though - as it is just hard-coded tables. Wouldn't it be easier to define the SC table simply as uint8's, and therefore not need any macro magic?
Re: SOFTWARE_LITTLE_BIT_ORDER
These may be left in the makefile due to cut-and-paste, but they are not serving any purpose as the code doesn't use them. In fact, these would be wrong if building UT for a big endian processor, which is IMO evidence why these //do// need to be purged out.
This change set is only currently removing these macros from the CMake build.
from osal.
Trac comment by acudmore on 2015-06-01 14:09:56:
Approve as this applies to the CMake build.
Comment 4 looks like a good case for removing the macros in the traditional make system. But we at least have to figure out what to do with the tables.
from osal.
Trac comment by jphickey on 2015-07-09 14:17:52:
== REBASED AND UPDATED ==
For the 2015-07-14 CCB review/discussion
- Commit [changeset:4aaaf64] contains the original modification rebased to the current OSAL development version.
- Commit [changeset:543eecb] contains an additional modification to address concerns about code out there that might still depend on {{{SOFTWARE_BIG_BIT_ORDER}}} or {{{SOFTWARE_LITTLE_BIT_ORDER}}}.
Both of these are merged into the {{{ic-2015-07-14}}} integration candidate for evaluation.
from osal.
Trac comment by glimes on 2015-07-13 12:51:23:
Approve.
from osal.
Trac comment by sduran on 2015-07-14 11:49:38:
Approve (compatibility macro is good)
from osal.
Trac comment by jwilmot on 2015-07-14 12:36:37:
Recommend accept.
from osal.
Trac comment by glimes on 2015-07-16 10:17:16:
Included in [changeset:ec67bd4 2015-07-14 development merge],
now present on Babelfish and IPAS-LIB.
from osal.
Related Issues (20)
- Cppcheck flagging BUGCHECK macro as syntax error
- Cppcheck flagging UT_DEFAULT_STUB as unknown macro
- Additional errors reported by new cppcheck HOT 2
- Support for FreeRTOS HOT 1
- Always build/provide OSAL stub library, decouple from ENABLE_UNIT_TESTS
- Variables declared mid-function
- Update CI to use Ubuntu 20.04
- Add doxygen dependencies to "doc-prebuild" abstract target
- Update workflows to use newer action versions
- Add better support for pointer return values in UT assert
- Add option to force RTEMS_FLOATING_POINT on all tasks
- Remove obsolete `_USING_RTEMS_INCLUDES_`
- Break up pc rtems bsp to support generic/configurable use
- Scrub for mismatched function prototype/implementation parameter names
- Stray remaining use of 'goto' in test code
- Add UtAssert_SIZET_EQ
- Add missing doxygen to new UT Assert API
- Designated initializer in `osapi-clock.h` header breaks C++ compilation unit. HOT 1
- Remove cast when starting timebase callback
- Add build script and workflow to validate API headers in C++
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osal.