CF - Incorrect cast in test functions about cf

[jphickey]

Imported comment by internal user on Tue Nov 16 19:07:44 2021

Another example/form of this same issue appears in Test_CF_CFDP_R2_GapCompute_WhenGiven_c_size_IsGreaterThan_0_Increment_gap_counter, where it has:

pdu_nak_t dummy_nak;

followed by:

dummy_args.ph = (pdu_header_t*)&dummy_nak;

The case to (pdu_header_t*) here is not valid, because pdu_nak_t is an extension of pdu_header_t, not a replacement of it.

A more correct way to declare the buffer would be:

struct

{ pdu_header_t ph; pdu_nak_t nak; } dummy;

And then simply take the address of the ph and nak members, respectively.