CF method CF_Assert call branches cannot be tested during unit testing about cf

[jphickey]

Imported comment by internal user on Wed Nov 17 10:31:54 2021

Many of the assert statements in CF are not necessary and may be candidates for outright removal. For example, inCF_CFDP_R2_SubstateSendFin.

sret = CF_CFDP_SendFin(t, t->state_data.r.r2.dc, t->state_data.r.r2.fs, t->history->cc);

CF_Assert(sret!=CF_SEND_ERROR); /* CF_CFDP_SendFin does not return CF_SEND_ERROR */

What value does it add to assert that a local function did not return the value it does not return? In reality it only matters if it was CF_SEND_SUCCESS or not. Assertions like this unnecessary clutter in the code.

[jphickey]

One possible solution here is to convert the assert statements into DEBUG asserts, and default to compiling them out. This way the information is still preserved in the code (i.e. that the value must be within some range or not NULL, etc) but these are not flagged as branches that are not covered in the tests. This way a user could still turn them back on if they want to.