Comments (3)
Lines 142 to 161 in 96cdf30
from cf.
While I do appreciate not wasting characters... neither ti
or t
are all that descriptive/helpful in terms of variable names. Maybe transaction
or txn
or similar? I'd consider either of these options more "readable".
from cf.
While I do appreciate not wasting characters... neither
ti
ort
are all that descriptive/helpful in terms of variable names. Maybetransaction
ortxn
or similar? I'd consider either of these options more "readable".
I would tend to agree with you Jake.
However, there are several hundred uses of all 3 options (t, txn & transaction) in the code base. So for now, it might be best to just correct this particular instance.
For CF_Transaction_t objects specifically, they practically all use ‘t’, so we can align these 2 aberrations to the majority, like Alan Gibson suggested.
Perhaps future work could focus on improving the argument names in general, to make them more readable.
from cf.
Related Issues (20)
- Implement dispatch pattern for CF
- Add EDS file for CF
- Fix typo in Requirement CF2002.1.3
- Various type mismatches in CF
- EDS file inconsistencies
- Should message buffers returned from `CFE_SB_ReceiveBuffer` be checked for `NULL`?
- Segfault trying to dereference NULL pointer.
- Apply name updates from recent EdsLib change
- Placing a file with a name that is too long in the polling directory causes errors to spam
- Inaccurate comment in CF_CFDP_ReceiveMessage
- cf delete file when there is an error during tx HOT 1
- Transaction priority sorted incorrectly
- Static analysis issues JSC 2.1
- Standardization of Command Responses
- EotPacket provides transaction status, but defines are internal
- f-sanitizer report run time error in coverage-cf-cf_cfdp_r-testrunner
- f-sanitizer report run time error in coverage-cf-cf_cfdp_sbintf-testrunner
- f-sanitizer report run time error in coverage-cf-cf_cfdp_s-testrunner
- f-sanitizer report run time error in coverage-cf-cf_cfdp-testrunner
- f-sanitizer report runtime error in coverage-cf-cf_cmd-testrunner
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cf.