Comments (4)
The same applies for 'algorithm' which should not be enclosed between ".
I've updated the patch: http://gist.github.com/259724
from httpclient.
Applied a patch from ibc: DigestAuth header quotation error: closed by 6f48800.
qup and algorithm is not required to be quoted. RFC2617 includes an
example 'qop="auth,auth-int"' though...
from httpclient.
The example in RFC 2617 'qop="auth,auth-int"' is in a response so in WWW-Authenticate or Proxy-Authenticate headers. In this case the "qop" grammar does require value enclosed between double quotes.
But in WWW-Authorization or Proxy-Authorization headers (this is, in HTTP requests) qop grammar is different, it can contain just one value so doesn't allow double quotes.
RFC 2617 section 3.2.1 The WWW-Authenticate Response Header:
qop-options = "qop" "=" <"> 1#qop-value <">
qop-value = "auth" | "auth-int" | token
RFC 2617 3.2.2 The Authorization Request Header:
message-qop = "qop" "=" qop-value
from httpclient.
You're right. Thank you!
ibc, since you know DigestAuth spec better than me, would you please check the fix for https://github.com/nahi/httpclient/issues/closed#issue/43, too if you can? Does the change look safe?
from httpclient.
Related Issues (20)
- Cookies with a SameSite attribute cause a warning to be output HOT 2
- Why HTTP::Status do not have 404 status code (not found)?
- Support connection to proxy via https scheme HOT 3
- Make a new release? HOT 3
- HTTPClient.create_request should not set content type for empty bodies
- warning: method redefined / assigned but unused variable
- [Chore] Documentation unavailable
- Timeout::timeout inherently unsafe, switch to socket nonblocking io
- Query on httpclient default gem default certificates
- Delete httpclient default gem default certificates
- Time for a release, maybe? HOT 6
- Issue parsing Digest challenge
- Connection to Lets Encrypt secured server fails HOT 14
- Test failures with webrick 1.7 HOT 3
- Cookies are added as multiple headers, which is invalid
- Is there any CI?
- support OpenSSL::SSL::SSLContext#add_certificate
- absolute URIs should not include a port component when the port matches the scheme default
- warning: mutex_m was loaded from the standard library HOT 3
- The existing WebAgent conflicts with the httpclient WebAgent class.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httpclient.