Coder Social home page Coder Social logo

Comments (5)

naggie avatar naggie commented on August 26, 2024

The issue: defaulting to "Artist" for "Album artist" if "Album artist" was not present. I suspect this would cause a problem if 2 albums have the same name without "Album artist" set.

For now I've removed the "Artist" default -- it's now "Various artists"

A possible solution is to hash the cover art if the "Album artist" is not set and use that to sort. Not sure how I will do that yet.

from crates.

naggie avatar naggie commented on August 26, 2024

It looks like we'll have to do a few tricks in order to solve this problem.

As far as I can see:

  1. Store bought, one-off or otherwise, the data contained within the headers is no coherent enough to us -- which is why MusicBrainz & AcoustID exist. However, MusicBrainz won't work for unlabelled music al the time.
  2. Single AudioFiles are consistent enough for a search based browsing (vosbox did it well)

Aside from manual curation (which we want to minimise) I think that we should index Audiofiles as-is (we can replace/deprecate to improve) and then derive a separate album (etc) from this.

Thoughts?

from crates.

naggie avatar naggie commented on August 26, 2024

Oh, and these "Broken albums" tend to be compilations of various artists -- some set the album artist to the individual artist.

from crates.

naggie avatar naggie commented on August 26, 2024

Going to make a classmethod on Album that tries to match or create an album:

Try desperately to match a current album, and as a last resort create a new one by:

  1. Try to match by MBID if it's there (probably isn't, yet)
  2. Looking for exact match of Album/Album artist if there is one (replace with better cover art if possible)
  3. Try matching by cover art hash if there is one (and replace "Album artist" with Various artists)
  4. Finally, make a new one.
  5. None

Also, possible filter on the Album name: Using a regex, remove substrings like:

  • cd2
  • disk 1
  • (cd1/4)

....that's assuming it's not useful to split by physical disk. It might be useful.

from crates.

naggie avatar naggie commented on August 26, 2024

Implemented.


Ha! It worked

from crates.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.