MSVC does actually require an explicit manifest, currently ignored about cargo-update

[nabijaczleweli]

Argh, I think I know why, can you try again with this patch applied?

diff --git a/src/main.rs b/src/main.rs
index ede6561..76a5455 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -1,6 +1,7 @@
 // This is so cargo actually considers linking to the fucking manifest,
 // since the build scripts' documentation can do the digital equivalent of fucking off
 #[cfg(target_os="windows")]
+#[cfg(target_env="gnu")]
 #[link(name="cargo-install-update-manifest", kind="static")]
 extern "C" {}

[liigo]

that means, no manifest is embedded (for msvc ABI), and can't be run without Administrator privilege

[nabijaczleweli]

Okay, so I have to work around that, too, now

[nabijaczleweli]

Can you try the fix/14-manifest-embed-msvc branch? It should build&link in an MSVC-compatible way.
If you get object type errors try replacing "--output-format=coff" with "--output-format=res", please.

[liigo]

I will

[mzji]

If the content of the manifest file won't be changed, then I think we don't need to compile it, we could just write the file with the name "cargo-install-update.exe.manifest" to the $HOME\.cargo\bin\ directory.

The advantage of this method is, we do not need to worry about the compiler toolchain/triples, the writing code will work on any Windows environment, since it only uses the std library.

[nabijaczleweli]

No

[liigo]

@nabijaczleweli
Branch fix/14-manifest-embed-msvc build failed.
I don't think there is a windres.exe in MSVC toolchain.

Edit: but you can try rc.exe.

[nabijaczleweli]

Updated the branch to use RC.EXE, try again, please?

[liigo]

@nabijaczleweli
After some changes to cargo-install-update-manifest.rc, build success.
But it doesn't work, the manifest resource was not linked into .exe.

Changes to cargo-install-update-manifest.rc:

@@ -1,2 +1,2 @@
-#include "winuser.h"
-1 RT_MANIFEST cargo-install-update.exe.manifest
+#define RT_MANIFEST 24
+1 RT_MANIFEST "cargo-install-update.exe.manifest"

---

If you don't mind, I'd like to have a try to submit a new pr.

[nabijaczleweli]

Have at it