Comments (10)
Oh, thanks a lot! I actually tried making the Podspec at a stage where cocoapods was not working very well with Xcode 8 yet (the validation tool was not possible to run)… and I'm no expert in using it. However, Carpaccio should be a simple one as we don't do anything clever with build settings. I'll take a look at the iOS build I've recently added in the Xcode project and report back in a bit ->
from carpaccio.
Oh, that Xcode based build for iOS is actually happily building now (also tests, including on travis – that CI was failing for a while because of Xcode 8 issues as well).
This is the full set of source code files that should be compiled in:
Carpaccio/Carpaccio/ImageLoaderProtocol.swift
Carpaccio/Carpaccio/Collection.swift
Carpaccio/Carpaccio/CGSize+Extensions.swift
Carpaccio/Carpaccio/BitmapImage.swift
Carpaccio/Carpaccio/RAWImageLoader.swift
Carpaccio/Carpaccio/ImageMetadata.swift
Carpaccio/Carpaccio/Image.swift
Carpaccio/Carpaccio/BitmapImage+iOS.swift
Carpaccio/Carpaccio/Collection+Extensions.swift
from carpaccio.
Ah, that RAWConverter.mm was actually a remnant of our earlier RAW converter code which was based on libraw – we since moved over to CoreImage. I've dropped those source files now from the repo, altogether with libraw etc static libraries that were still in the repo and no longer necessary.
from carpaccio.
Just be sure to use the latest (currently pre-release) version of CocoaPods.
from carpaccio.
Thanks, that got me a bit further (progress pushed to master) – maybe you know how to finish this off?
- I've now got as far as having
pod spec lint
fail as it's evidently using the Swift 2.3 compiler to build. - Based on what I've read (I'm a Carthage man myself, not used cocoapods really in production), fixing this doesn't appear to be a Podspec level issue but that there are presently some hacks on the level of a Podfile to make cocoapods behave.
- Not sure how I would incorporate any of that into actually checking this pod validates?
from carpaccio.
Looking at your fork btw, the Includes
directory, the header search paths entries pointing at it, all the static libraries btw are all actually unnecessary and I've removed those today evening now from confusing people from the repo (they all predate the actual CoreImage based form of the code).
All in all this should really be as simple a pod as it gets – the Xcode configuration literally just compiles that handful of source files and links against AppKit / UIKit.
from carpaccio.
I'll investigate tomorrow. As far as I understood, you need CocoaPods 1.1.0.rc.2 for Swift 3.0
from carpaccio.
Yep, it seems to all work now – pod install / update works with the Swift compiler version set in the containing target. Tested with this tiny Podfile hooked to a made up Foobar Xcode macOS app target:
target 'Foobar'
platform :osx, '10.10'
use_frameworks!
pod 'Carpaccio', :git => '[email protected]:mz2/Carpaccio.git', :branch => 'master'
(iOS should be fine too)
What I wasn't able to work out yet successfully is how to get pod spec lint
to behave with it. This may be why cocoapods 1.1.0.rc.2 still a prerelease :-)
from carpaccio.
Yep, a few more tweaks were still necessary, now up – the Swift compiler version can now be hinted for pod spec lint
by creating a .swift-version
file in the repo.
from carpaccio.
Please reopen if you hit any issues with building Carpaccio as a cocoapod.
from carpaccio.
Related Issues (10)
- Support for more metadata fields? HOT 1
- Xcode 13 Beta HOT 4
- Make build pass on Xcode 13 beta 5
- Separate `exifdump` into its own Package.swift
- CIImage creation out of Sony ARW from iOS HOT 1
- ImageMetadata loaded with loadFullSizeImage doesn't contain valuable information HOT 3
- Image size related test failure HOT 1
- Not working with Fuji RAF files HOT 11
- Cannot select "Carpaccio.xcodeproj" in "Embedded Binaries" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carpaccio.