Coder Social home page Coder Social logo

Comments (6)

MylesFTOP avatar MylesFTOP commented on July 29, 2024

Now added and reporting via Codecov - current coverage for LuhnLibrary is 88.9%, with only one method uncovered (CheckLuhnSuffixReturnString, which is essentially a wrapper for CheckLuhnSuffixReturnBool to return strings of "valid" or "not valid" instead of a boolean).

from luhncheck.

MylesFTOP avatar MylesFTOP commented on July 29, 2024

Added to Github Action with commits 7c73567. Coverage has dropped from 89% to 22%, as command-line instruction to exclude LuhnLibrary (which is only UI logic) does not appear to have processed.

from luhncheck.

MylesFTOP avatar MylesFTOP commented on July 29, 2024

Commit e201397 added /p:CollectCoverage=true to dotnet test, which shows that the exclude parameter isn't being picked up from the command line (despite it both having had versions with and without escaped quotes). Need to look into this further.

from luhncheck.

MylesFTOP avatar MylesFTOP commented on July 29, 2024

Anecdotally, I have noticed that the exclude/include parameters don't seem to pick up from the runsettings whenever I've used it on local builds (which is why I still kick it off from the command line). Will try adding it to the runsettings now to see if it works from Github.

from luhncheck.

MylesFTOP avatar MylesFTOP commented on July 29, 2024

Exclude is now working on the command line using unescaped quotes (showing 90% coverage, as lines containing just method names and braces appear to have been excluded from the latest run - compare before and after).

Identical exclude is present in coverlet.runsettings, so will remove the exclude from the command line.

from luhncheck.

MylesFTOP avatar MylesFTOP commented on July 29, 2024

Removed command line exclude in ac44a9b, but even though the Actions output and coverage report both show that LuhnCheck was included in the analysis (see previous coverage report that did not analyse LuhnCheck when /p:Exclude="[LuhnCheck]*" was on the command line), the Codecov statistic still shows 90% coverage (i.e. it is only taking LuhnLibrary into account as specified).

It seems that if the Exclude parameter is passed in at the command line, it does not analyse any assemblies specified, but if it is passed in from the runsettings, it will analyse those assemblies but ignore them from the final statistic.

from luhncheck.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.