Comments (6)
Now added and reporting via Codecov - current coverage for LuhnLibrary is 88.9%, with only one method uncovered (CheckLuhnSuffixReturnString
, which is essentially a wrapper for CheckLuhnSuffixReturnBool
to return strings of "valid" or "not valid" instead of a boolean).
from luhncheck.
Added to Github Action with commits 7c73567. Coverage has dropped from 89% to 22%, as command-line instruction to exclude LuhnLibrary (which is only UI logic) does not appear to have processed.
from luhncheck.
Commit e201397 added /p:CollectCoverage=true
to dotnet test
, which shows that the exclude parameter isn't being picked up from the command line (despite it both having had versions with and without escaped quotes). Need to look into this further.
from luhncheck.
Anecdotally, I have noticed that the exclude/include parameters don't seem to pick up from the runsettings whenever I've used it on local builds (which is why I still kick it off from the command line). Will try adding it to the runsettings now to see if it works from Github.
from luhncheck.
Exclude is now working on the command line using unescaped quotes (showing 90% coverage, as lines containing just method names and braces appear to have been excluded from the latest run - compare before and after).
Identical exclude is present in coverlet.runsettings
, so will remove the exclude from the command line.
from luhncheck.
Removed command line exclude in ac44a9b, but even though the Actions output and coverage report both show that LuhnCheck was included in the analysis (see previous coverage report that did not analyse LuhnCheck when /p:Exclude="[LuhnCheck]*"
was on the command line), the Codecov statistic still shows 90% coverage (i.e. it is only taking LuhnLibrary into account as specified).
It seems that if the Exclude
parameter is passed in at the command line, it does not analyse any assemblies specified, but if it is passed in from the runsettings, it will analyse those assemblies but ignore them from the final statistic.
from luhncheck.
Related Issues (19)
- TestTheData does not use strings from InputString HOT 1
- Remove duplication in unit tests HOT 1
- CalculateLuhnDigit does not reduce doubled digits that exceed 9
- CalculateLuhnDigit does not add the first digit checked into the string HOT 2
- Action fails on dotnet build and dotnet test due to missing reference assemblies HOT 4
- Luhn algorithm is not implemented correctly
- Add unit tests for ConsoleApp.cs
- Extract instantiation to new class
- Luhn calculation method does not return correct check digit HOT 1
- Migrate LuhnCheck and LuhnLibrary to .NET Core
- Complete coverage for CheckLuhnSuffixReturnString HOT 1
- luhnDigit is not reduced to a single digit at the end of the calculation HOT 3
- Add unit test coverage to project HOT 2
- Move method CalculateLuhnDigit into class library HOT 1
- Abstract current use case to AddSuffix method HOT 1
- Add method to validate existing suffix as ValidateSuffix HOT 1
- Make command line interface more explicit HOT 1
- AddLuhnSuffix() and CheckLuhnSuffix() are not consistent HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from luhncheck.