Add get_*() methods to the datahandlers about mybb

[DennisTT]

Originally the data handlers were designed to have consistent and reusable code for input validation. They weren't meant as a full "model" layer of a MVC application (as you are probably referring to), since 1.x doesn't have a MVC foundation, nor real OOP practices.

Moving forward, yes it would make sense to do so especially when we move to MVC or some other OOP pattern.

Dennis

On 2013-03-18, at 11:07 AM, Euan T. [email protected] wrote:

I've never understood why the likes of get_user() are standalone functions instead of methods of the datahandler classes. The datahandler classes should, in my opinion, perform all CRUD operations for the data entities they're meant to handle.

This would make developing on top of MyBB make a lot more sense as one wouldn't need to require in a large file with many unnecessary functions and can simply require the datahandlers they need and any other classes (DB_*, cache handlers etc).

In order to maintain backwards compatibility with the 1.6.x series, we could have the usual get_*() function act as aliases to the class methods.

Just some food for thought.

—
Reply to this email directly or view it on GitHub.

[euantorano]

Fair enough. I can wait I guess till 2.0.