Bug when removing a member from a group that could become invisible about mybb

[Walter-Correa]

Until this is corrected I will hide this information in forumdisplay_userbrowsing and showthread_userbrowsing!
<span class="smalltext">{$lang->users_browsing_forum} {$onlinemembers}<!--{$onlinesep}{$invisonline}-->{$onlinesep2}{$guestsonline}</span><br />

[dvz]

The canbeinvisible conditions added in #4065:

if($user['invisible'] == 1 && $mybb->usergroup['canbeinvisible'] == 1)

seem incorrect, as they only refer to the viewing user.

We can remove them to fix the count error for users with { invisible = 1 & canbeinvisible = 0 } that may result in -1 because of:

• mybb/forumdisplay.php

  Lines 337 to 341 in 526feb9

  	if($mybb->user['invisible'] == 1)
  	{
  	// the user was counted as invisible user --> correct the inviscount
  	$inviscount -= 1;
  	}

• mybb/showthread.php

  Lines 1617 to 1621 in 526feb9

  	if($mybb->user['invisible'] == 1)
  	{
  	// the user was counted as invisible user --> correct the inviscount
  	$inviscount -= 1;
  	}

This would still leave updating mybb_users.invisible after usergroup changes.