Permgen Leak in TomEE. about cdi

[emacarron]

Hi @tonywestonuk can you make the change yourself and send a pull request?

[hazendaz]

@emacarron I took a look around in guice since it would seem logical that if this has a leak there is one over there too. And there certainly was and it was fixed long ago. I have added the above code where noted and will perform a pull request but not completely sure if that is the right spot so I will let that sit until further review. I know I'll want to run some live tests on this and I'm still about 3 months off from finally getting switched over to using mybatis-cdi over some internal cdi solution I created years ago.

[emacarron]

@hazendaz Ok. Do the change and let me know. I will have a look at it and tell you. Thank you!

[hazendaz]

This still needs tested but I went ahead and merged it since guice module has same code and we are getting backed up on outstanding version updates ;) I still plan to use this version when I get time. Last I tested I was running into some odd issues (possibly unrelated) but in my actual use case we are still a ways off from switching from home grown version of this to the official copy. And it seems I cannot find time these days to really get in there so I just going to push forwards and when I do get to this I'll confirm and close this out then. That is unless someone else tests first and can close this ;)

[hazendaz]

I'm going to go ahead and release this with the fix noted. I'll do some higher level tests after release. These days it's hard to get usage in place without jumping lots of hoops so will just release then follow-up on some testing...

[mnesarco]

It looks like this is fixed in commit 59937fe can we close this issue?

[mnesarco]

Hi @hazendaz , can we close this issue? it seems that you have fixed this long time ago.

[hazendaz]

I didn't test the solution but I think based on guice fix of the same that the issue is resolved.

@tonywestonuk Is this something you can test again on latest beta and let us know if this is still an issue?

[mnesarco]

Fixed in 59937fe