Comments (2)
Hi. Thank you very much for looking into node-milight-promise and your feedback!
The basic rationale behind using synchronized promises rather than a message queue is to have more flexibility with respect to setting the synchronization points in the code. Actually, _synchronize
is used for the socket initialialization (am I ready to send?), the sendCommand, the Socket Closure (close if there are no pending promises), and it is optionally used to synchronize multiple Milight instances.
Needless to say the code has grown over time and things could be simplified for sure using an approach similiar to what you're suggesting. At a frist glance, I'd prefer a queue of functions (or promises), however. I need to look into this in more detail, however, to decide on the best approach. Some refactoring is on my todo list list anyway also to modernize the code with respect to the advancements of Javascript.
from node-milight-promise.
I am closing this now as the question has been answered. I'll revisit the matter at a later stage as part of the refactoring work
from node-milight-promise.
Related Issues (20)
- Seeking help HOT 3
- Add TCP-Support for v6.0 HOT 3
- node-milight-promise not controlling bridge HOT 4
- Version 10 of node.js has been released HOT 1
- Support Question HOT 3
- How to change bulb temp? HOT 3
- Possible to ignore previous commands and run last command first? HOT 1
- Inconsistent colors across commands HOT 2
- On/Off does not work with RGBW One Zone Dimmer HOT 14
- How can I set a color value? HOT 15
- Need help on how to use the legacy bridge with command2 HOT 6
- Can somebody help turn zone 5 on/off? HOT 2
- Bitte single statt singe HOT 1
- Buffer() is deprecated HOT 1
- changing the delay before light turns on after hitting a switch HOT 2
- How do I change the Color temperature? HOT 3
- YL5 LED strip controller support HOT 11
- New integration for ha-bridge HOT 1
- Unable to connect to Milight YT1
- Controlling all zones simultaneously HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-milight-promise.