Coder Social home page Coder Social logo

Comments (4)

jku avatar jku commented on July 1, 2024 1

Sdist should include the sources and tooling required to build the binary distribution. I would definitely argue the requirements file is part of that tooling.

we remove the possibility of installing dependencies through Test PyPI when installing this project

This makes no sense to me: the user calling pip decides which repository they use.

from oss-eu-2022-tutorial-mv.

jku avatar jku commented on July 1, 2024

requirements file is also not in sdist

from oss-eu-2022-tutorial-mv.

MVrachev avatar MVrachev commented on July 1, 2024

requirements file is also not in sdist

As this file is for build requirements I don't it needs to be in sdist.
Also, that way we remove the possibility of installing dependencies through Test PyPI when installing this project.

from oss-eu-2022-tutorial-mv.

MVrachev avatar MVrachev commented on July 1, 2024

I fixed that and the workflow is using the requirement file and the requirement file is renamed to requirements-build.txt.

from oss-eu-2022-tutorial-mv.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.