Comments (15)
I like that yes, this is more flexible.
I think that would be a good idea to add a "grouping" parameter
Instead of log(str) we could have log(group, level, str) which would output
EXIF | Error
FUJIDELE | Error
instead of the current just
Error
Error
from focus-points.
sure, i would just say, separate the log levels to different methods; 1 for each level. It's more common such as in LrLogger and Android Log
logInfo(method, message)
...
logError(method, message)
from focus-points.
yep
from focus-points.
yours.
reference:
https://github.com/musselwhizzle/Focus-Points/tree/feature/prefs_pane
from focus-points.
due to having so many feature branches out right now, please dont refactor all log statements just yet. It will make it harder to merge the conflicts. Just setup the feature/code and we'll do another pass for moving from log(str)
to the new code once merges are in.
from focus-points.
Yes, understood.
from focus-points.
Is this possible easily ?
from focus-points.
git fetch -- gets all the latest branch names from your remote repo
git checkout branch_name -- checks out an existing branch
git checkout -b branch_name - creates a new branch based off of where you currently are
git push -u origin branch_name - sends new local branch to remote repo (your personal fork) and sets up tracking
checkout whatever branch you want, probably this
git fetch
git checkout feature/fix_display_rotation
git pull
git checkout -b feature/your_new_feature
-- do work
-- add
git push -u origin feature/your_new_feature
you can merge in and out of branches easily if works is separated by feature.
from focus-points.
from focus-points.
from focus-points.
Sorry, I changed it from master to feature/prefs_pane and then apparently didn't click merge but closed the PR. I merged it in now and can see the file here:
https://github.com/musselwhizzle/Focus-Points/blob/feature/prefs_pane/focuspoints.lrdevplugin/FocusPointPrefs.lua
from focus-points.
Sorry, forget it. I think I misunderstood you.
I thought you had merged the PR of the guy who did the pref panes example into the branch feature/prefs_pane.
As I understand, you just did open the branch for me.
from focus-points.
ah ok, so we have it now !
from focus-points.
Solved by PR #85
from focus-points.
requested a change in the PR, but merged anyway.
from focus-points.
Related Issues (20)
- Panasonic GX85
- Pentax *ist files fail on WIndows HOT 1
- cameraMake for Nikon cameras
- '*' in Pentax mapping files HOT 3
- Meaningfulness of center dot
- White Screen and Focal Point HOT 1
- fails with olympus .orf files from em1 mark2 as well as nikon z7 .nef files HOT 16
- Focus point rendering fails if filename contains space(s) - windows version on HOT 1
- Support for Nikon Z-series of cameras
- Supported Sony cameras HOT 1
- Suggestion: Enhanced EXIF data browsing HOT 5
- Installation HOT 4
- thank you for this plugin HOT 1
- Improved support for Sony RX10M4 HOT 5
- OMDS OM-1 (Olympus) not compatible HOT 1
- Panasonic LUMIX G9 AI animal AF
- Metadata display slow for EXIF data containing items with very long values
- Fujifilm Subject Detection HOT 1
- Support for Nikon D300
- New Olympus OM-1 HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from focus-points.