Coder Social home page Coder Social logo

Comments (8)

jcao02 avatar jcao02 commented on July 17, 2024

I'll probably make a PR to add this feature. Should I do it from your dev branch? @MurhafSousli

from ngx-sharebuttons.

MurhafSousli avatar MurhafSousli commented on July 17, 2024

@jcao02 yupp it's fine 👍

from ngx-sharebuttons.

jcao02 avatar jcao02 commented on July 17, 2024

@MurhafSousli the branch doesn't seem to be stable right now. I get an error when compiling with angular-cli:

ERROR in Error encountered resolving symbol values statically. Could not resolve ng2-sharebuttons relative to ...

Is it a problem if I use you master branch for the PR?

from ngx-sharebuttons.

MurhafSousli avatar MurhafSousli commented on July 17, 2024

@jcao02 in root dir, do gulp build then gulp link then gulp demo, ofcourse don't forget to npm install in demo first

from ngx-sharebuttons.

MurhafSousli avatar MurhafSousli commented on July 17, 2024

@jcao02 in case it didn't work for you, copy src to demo/src/share and import from there temporary, but don't include these changes in the PR

from ngx-sharebuttons.

MurhafSousli avatar MurhafSousli commented on July 17, 2024

@jcao02 It seems that whatsapp button is not working in 2.0.0@beta, have you tried it?

from ngx-sharebuttons.

jcao02 avatar jcao02 commented on July 17, 2024

Yes. I'm using this package while you release the last version, it's the dev branch from my fork. The button only works from a smartphone, though (The link opens the native app)

from ngx-sharebuttons.

MurhafSousli avatar MurhafSousli commented on July 17, 2024

This need to be fixed for the web too

from ngx-sharebuttons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.