Comments (9)
I am afraid this is out of the scope for this project.
This is just a wrapper package of highlight.js
and it depends on it, it works the standard npm. for other tools - developers should figure it out on their own.
from ngx-highlightjs.
its ngx-highlightjs
from ngx-highlightjs.
its
ngx-highlightjs
That's a typo, but the problem remains
from ngx-highlightjs.
I don't use pnpm, shouldn't it work like yarn? or I have to publish the package to pnpm?
from ngx-highlightjs.
@MurhafSousli I think the problem is with highlight.js
resolving. pnpm or yarn pnp doesn't linking it.
Possible solution is installing directly to project:
pnpm install highlight.js
from ngx-highlightjs.
@MurhafSousli second option:
add to .npmrc:
public-hoist-pattern[]=*highlight.js*
from ngx-highlightjs.
@MurhafSousli so the idea is to make ngx-highlightjs works like solid package. Library should work like line-numbers
example:
coreLibraryLoader: () => import('highlight.js/lib/core'),
languages: {
css: () => import('highlight.js/lib/languages/css'),
scss: () => import('highlight.js/lib/languages/scss'),
typescript: () => import('highlight.js/lib/languages/typescript'),
xml: () => import('highlight.js/lib/languages/xml'),
},
should be replaced with:
coreLibraryLoader: () => import('ngx-highlightjs/highlight-lib'),
languages: {
css: () => import('ngx-highlightjs/languages/css'),
scss: () => import('ngx-highlightjs/languages/scss'),
typescript: () => import('ngx-highlightjs/languages/typescript'),
xml: () => import('ngx-highlightjs/languages/xml'),
},
from ngx-highlightjs.
This is a dependency, how can you receive updates and fixes from the main package then?
from ngx-highlightjs.
@MurhafSousli
pnpm uses linking to node_modules: Flat node_modules is not the only way
So, for libraries there are 2 approaches:
- Add instructions for pnpm: as i said
- users needs to install
highlight.js
directly to their projects - or add
public-hoist-pattern[]=*highlight.js*
to .npmrc
- users needs to install
- Add re exports:
-
const core = import('highlight.js/lib/core'); export default core;
-
from ngx-highlightjs.
Related Issues (20)
- Highlight.js library was not imported and cannot read property 'themePath' of undefined HOT 16
- Angular async pipe return type is 'string|null' not 'string' as [highlight] expect. HOT 5
- ERROR TypeError: Cannot read properties of null (reading 'themePath')
- Support loading of relative URLs HOT 2
- Usage in Angular module: Error: inject() must be called from an injection context HOT 1
- npm cannot resolve peer dependency @angular/common@">=14.0.0" from [email protected] HOT 1
- Could not find a declaration file for module 'highlightjs-line-numbers.js' - Show line numbers HOT 6
- The gist class member of the GistDirective is private
- Angular Universal - ERROR ReferenceError: requestAnimationFrame is not defined HOT 10
- Binding data from innerHtml HOT 5
- setTheme does not load theme if `themePath` was not specified in the configuration HOT 1
- line-number and styling not being applied for json HOT 3
- Angular 16
- Using ngx-highlightjs in stand-alone components
- Your documentation is probably outdated HOT 1
- (love) Just to tell you how great your software is HOT 2
- Add line numbers options HOT 1
- Multiline strings on C# breaks highlighting HOT 3
- Property '"code"' is incompatible with index signature. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-highlightjs.