Coder Social home page Coder Social logo

Comments (6)

paulscode avatar paulscode commented on June 18, 2024

Pelya wrote this code, so I'll stop by his thread to see if there is any discussion about this (we might be outdated). Might be worthwhile to study the code and see what is being accomplished there. I'll take a look.

from mupen64plus-ae.

littleguy77 avatar littleguy77 commented on June 18, 2024

Yes DataDownloader may need a re-look. I think at the moment we are just using it to unzip files. Wonder if Android has any new utilities for this?

from mupen64plus-ae.

lioncash avatar lioncash commented on June 18, 2024

If you want something to just unzip files, I made this a while ago when I was first learning file streams in java.

https://gist.github.com/cded7f100838ef4e3918

It extracts a zip file, given the path to the zip and the desired directory to extract them to. Maybe that can help somewhat ?

from mupen64plus-ae.

littleguy77 avatar littleguy77 commented on June 18, 2024

Taking a step back... What if we just put the uncompressed data in the assets folder? It will still get compressed in the APK, so it doesn't change APK size. The only difference is where the data gets stored on the user's filesystem. One benefit would be that we don't have to manually check versions and update the data if it ever changes... it simply gets overwritten when the user updates/installs the APK. We could get rid of the DataDownloader class and we wouldn't even need the splash screen (even though I love the graphic :). Would vastly simplify the logic in MainActivity.

But I'm guessing there's more to it than that?

from mupen64plus-ae.

littleguy77 avatar littleguy77 commented on June 18, 2024

Ok, should have known it's not this simple. Android keeps files in the assets directory compressed, and you can't access them using ordinary java.io.File methods. I'm guessing you already knew all that ;)

from mupen64plus-ae.

paulscode avatar paulscode commented on June 18, 2024

Yes, that is the main reason (plus the nice splash image). Although the downloading functionality isn't currently being used, I like having it there for potential future expansion. For example it could be used for fun things like downloading box art, pulling from a community plug-in repository, grabbing hires texture packs, etc.

from mupen64plus-ae.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.