Comments (1)
Hi @anthonyvdg-se ,
Thank you for your message.
We have looked into this before and the tricky part is that we actually do process the cancel of the order inside the incoming MultiSafepay webhook to the notification controller, but sometimes this webhook can have a few seconds delay. So whenever someone clicks on the cancel button and we would process the decrement of the coupon on the webhook instead, it could be that their quote will not have the restored coupon inside it, because Magento restored the quote at the moment the coupon was not decremented yet. So someone could then see their quote restore, but their coupon not being returned.
They can still add the coupon back to the quote, but only after the webhook has processed the decrement. You could also argue for the reason why we do not decrement the coupon in both places, the incoming webhook and the Cancel controller, but sometimes the incoming webhook will process the decrement at exactly the same time and will result in double decrements due to race conditions.
I will look into decrementing the coupon when we cancel the order in the incoming webhook and come back to you with an update later.
from magento2-frontend.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento2-frontend.