Comments (6)
Hi Jim, PIN challenges are hardcoded to workflows? If they're implemented
properly - as event handlers for PinMatrixRequest, no change in client
codebase is required.
Best,
Marek
On Wed, Apr 1, 2015 at 11:32 AM, Jim Burton [email protected]
wrote:
There is a breaking change in Trezor 1.3.3 firmware - GetPublicKey now
issues a PIN challengeReply to this email directly or view it on GitHub
#15.
from multibit-hardware.
We use event handlers, we just don't expect all events in all workflows.
This translates up the stack into MBHD where wizard screens progress based on expected events rather than randomly skip around due to unexpected messages being pushed from the device.
from multibit-hardware.
I see. However, it should be pretty straightforward to change event handler to expect PIN and/or passphrase (well, you don't support passphrases yet, but the logic is the same) messages for virtually any message.
Also, Trezor uses caching mechanism for PIN and passphrase, so not every "PIN protected" message will trigger PinRequest on every call.
from multibit-hardware.
Yes, it's a breaking change for us but not a difficult one. The ConfirmGetPublicKey simply needs support for PIN added.
This then bubbles up to MBHD to trigger the PIN handling in the FSM backing the credentials wizard.
from multibit-hardware.
As Gary states, it's not a big issue.
There will most likely be a gap in time from when Trezor 1.3.3 comes out and when we release MBHD Beta 8 (as we have other stuff to get in) but it should not be problematic.
from multibit-hardware.
Verified working.
Closing.
from multibit-hardware.
Related Issues (20)
- Improve shutdown process when no Trezor is attached HOT 2
- Simplify staging repository configuration HOT 2
- Support for P2SH is missing HOT 2
- Add support for MultiBit Commons HOT 2
- Add support for Ping HOT 2
- Add support for Bitcoinj 0.13.2 Alice 0.1.3 HOT 1
- Getting `Device not attached` error HOT 4
- Trezor API - SignIdentity msg support HOT 9
- Trezor API - Add support for Encrypt/Decrypt Message
- Trezor API - Add support for seed phrase recovery
- org.multibit.hd.hardware.core.domain.Identity - obstructing validation HOT 6
- Trezor API - Add support for passphrase HOT 2
- Trezor API - Identity URI bug HOT 1
- Trezor API - Multisession Operation HOT 1
- Trezor API - USB attach takes long time HOT 15
- Include a proper license header in source files
- TREZOR 1.4.0 fails on Windows HOT 3
- Trezor Examples only work intermittenly
- For more security spongycastle -> bouncycastle
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from multibit-hardware.