Coder Social home page Coder Social logo

Comments (13)

hai-cea avatar hai-cea commented on April 24, 2024

I agree :) Although, I don't have much experience with Sass. Would love some help on this one.

from material-ui.

parris avatar parris commented on April 24, 2024

I'd say having a css distributable would be the way around most of these issues.

from material-ui.

twisterghost avatar twisterghost commented on April 24, 2024

+1 to a distributable .css file. The internals of the package shouldn't really matter unless someone was looking to fork it and edit the guts of the LESS for their own project, in which case, I don't think its on the maintainer to provide that (which would imply you would need to supply stylus and pure css as well).

from material-ui.

una avatar una commented on April 24, 2024

+1 to both a .scss file and a compiled .css version. Sass is widely used and having options could solve some of the issues

from material-ui.

hai-cea avatar hai-cea commented on April 24, 2024

You can check out #56 for discussions about creating a .css distributable.

from material-ui.

dmcclintock avatar dmcclintock commented on April 24, 2024

I'm willing to contribute towards a SASS port, since there seems to be some interest. I think that would be crucial in the long run for encouraging adoption with some of the major frameworks such as Foundation and Bootstrap. Will fork it and dig into the code over the weekend to see what all would be involved... Really love what you guys have done here by the way.

from material-ui.

gpbl avatar gpbl commented on April 24, 2024

@danielsmcclintock if you need help for that, I can help. I can't stay sassless.

from material-ui.

gpbl avatar gpbl commented on April 24, 2024

I've started a small repo: material-ui-sass where I would convert from less to sass the CSS framework. Never made something like this before, so I don't know how hard will it be and how we could keep the things in sync. Luckily it looks like the less files are simple and solid enough...

@DUBERT @danielsmcclintock and others, who wants to join? :-)

@hai-cea please tell me if you don't agree with this idea, maybe we should do this in another way...

from material-ui.

una avatar una commented on April 24, 2024

I'd love to help too, @gpbl :)

from material-ui.

hai-cea avatar hai-cea commented on April 24, 2024

@gpbl Thanks for taking this on! 👍

from material-ui.

dmcclintock avatar dmcclintock commented on April 24, 2024

@gpbl thx for taking the initiative. I was out of pocket last week, so wasn't able to start earlier as I wished. I forked this repo earlier, but it makes no difference which one serves as the main trunk...as long as we kick ass and take names. :) I'm fine with forking your repo and submitting pull requests to you as long as you're comfortable managing the pull requests/issues, and keeping it on track with this repo.

Open to any feedback from @hai-cea also.

from material-ui.

gpbl avatar gpbl commented on April 24, 2024

I'm finished with the conversion, we can now use sass as well! Please check material-ui-sass. Suggestions and improvements are welcome.

@hai-cea thank you for allowing us doing this. I'm sure people using Sass will appreciate. Would you like add a reference to material-ui-sass in the README.md?

from material-ui.

hai-cea avatar hai-cea commented on April 24, 2024

@gpbl yes that's good idea - do you want to submit a PR?

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.