Comments (11)
Yes, you can create a PR to add this feature in Material UI Breadcrumbs component.
from material-ui.
@duynguyen-kun I have reviewed your PR.
from material-ui.
Why use breadcrumbs to trigger a menu? These two UI components shouldn't be combined. Can you provide an example of this in a real world application?
from material-ui.
Hi @ZeeshanTamboli,
Similar to these ones, when there are too many items being hidden within the ellipsis, e.g: 4 or 5 items, it would be convenient to view all of them as a menu instead of exposing everything which might result in developers having two concerns:
- The breadcrumbs are horizontally taking all the spaces of the viewport. We might need to think of breaking them into multiple lines
- When the labels are too long, we need to think of how we should truncate them into smaller length of text.
from material-ui.
Just found some examples of using overflow menu for accessibility enhancement.
from material-ui.
I see this is supported in Joy UI: https://mui.com/joy-ui/react-breadcrumbs/#condensed-with-menu.
We can add this new feature. Feel free to work on it.
from material-ui.
That's nice. However, it'd be ideal if my repo wouldn't have to install another dependency like Joy UI just for that behavior. So what you mean is I can create a PR for this? Or is there anything I can do to get this feature implemented?
from material-ui.
Hi @ZeeshanTamboli ,
Do you mind take a look at my PR? Let me know if I need to update anything regarding the contributing guides (so far i know i haven't updated docs API)
from material-ui.
Hello @ZeeshanTamboli! I'm beginning work on adding this feature. Could you please assign it to me?
from material-ui.
@ZeeshanTamboli PR is ready for review.
from material-ui.
@ZeeshanTamboli after reviewing the ask again. I realized that the original ask from issue was to be able to create the menu functionality similar to the Joy package example. That is currently possible without any code changes. I updated the PR to instead update the documentation to demonstrate how this can be implemented using the MUI package.
@duynguyen-kun I believe you are wanting to implement something like this:
https://github.com/mui/material-ui/pull/42973/files#diff-5e9f55b9f0c001a9bc86e156849c1ce1b0e52693a47a3e4b8a49a8d6a91665b3
from material-ui.
Related Issues (20)
- Make more compatible with Terser Mangler HOT 1
- TS Module Augmentation: Allow adding a new color to all components HOT 1
- [Joy-ui] [Table] Focus style on table rows is inconsistent
- [material-ui] Outlined Input component needs to get min value for its number type! HOT 1
- [material-ui][Select] Changing IconComponent makes the new icon unclickable HOT 2
- [material-ui][TextField] The override for MuiTextField does not work after changing from version 5.15.21 to 5.16.4 HOT 5
- [docs] StylesProvider to avoid ID changes with RTL snapshots HOT 1
- [MUI/Autocomplete] make selected values available to FormData
- Keyboard scrolling doesn't work in fullscreen Dialog
- Styles not added to shadow DOM when wrapping MUI in a library HOT 2
- [joy-ui] Overriding Drawer Size throws browser error in Dev build HOT 1
- Autocomplete freeSolo type search not allowed to change/edit the clearIcon
- Button from @mui/material conflicts with @react-three/drei
- Getting Error: Element type is invalid when using IconButton HOT 2
- OutlinedInput should have helperText and other features that Text Field has HOT 1
- Bug: Options visually selected after clicking the clear selections button in the Select component
- [core] Can't install `@mui/material@next` and `@mui/material-nextjs@next` HOT 1
- Error in multiple Select: Cannot read properties of undefined (reading 'value') at SelectInput.js:394:63
- Add Repobeats (metrics) to README
- Type erros in `@mui/utils` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-ui.