Coder Social home page Coder Social logo

Comments (11)

ZeeshanTamboli avatar ZeeshanTamboli commented on July 22, 2024 1

Yes, you can create a PR to add this feature in Material UI Breadcrumbs component.

from material-ui.

ZeeshanTamboli avatar ZeeshanTamboli commented on July 22, 2024 1

@duynguyen-kun I have reviewed your PR.

from material-ui.

ZeeshanTamboli avatar ZeeshanTamboli commented on July 22, 2024

Why use breadcrumbs to trigger a menu? These two UI components shouldn't be combined. Can you provide an example of this in a real world application?

from material-ui.

duynguyen-kun avatar duynguyen-kun commented on July 22, 2024

image
image

Hi @ZeeshanTamboli,
Similar to these ones, when there are too many items being hidden within the ellipsis, e.g: 4 or 5 items, it would be convenient to view all of them as a menu instead of exposing everything which might result in developers having two concerns:

  1. The breadcrumbs are horizontally taking all the spaces of the viewport. We might need to think of breaking them into multiple lines
  2. When the labels are too long, we need to think of how we should truncate them into smaller length of text.

from material-ui.

duynguyen-kun avatar duynguyen-kun commented on July 22, 2024

Just found some examples of using overflow menu for accessibility enhancement.

  1. carbondesignsystem
  2. NextUI
  3. Adobe

from material-ui.

ZeeshanTamboli avatar ZeeshanTamboli commented on July 22, 2024

I see this is supported in Joy UI: https://mui.com/joy-ui/react-breadcrumbs/#condensed-with-menu.

We can add this new feature. Feel free to work on it.

from material-ui.

duynguyen-kun avatar duynguyen-kun commented on July 22, 2024

That's nice. However, it'd be ideal if my repo wouldn't have to install another dependency like Joy UI just for that behavior. So what you mean is I can create a PR for this? Or is there anything I can do to get this feature implemented?

from material-ui.

duynguyen-kun avatar duynguyen-kun commented on July 22, 2024

Hi @ZeeshanTamboli ,
Do you mind take a look at my PR? Let me know if I need to update anything regarding the contributing guides (so far i know i haven't updated docs API)

from material-ui.

Sergio16T avatar Sergio16T commented on July 22, 2024

Hello @ZeeshanTamboli! I'm beginning work on adding this feature. Could you please assign it to me?

from material-ui.

Sergio16T avatar Sergio16T commented on July 22, 2024

@ZeeshanTamboli PR is ready for review.

from material-ui.

Sergio16T avatar Sergio16T commented on July 22, 2024

@ZeeshanTamboli after reviewing the ask again. I realized that the original ask from issue was to be able to create the menu functionality similar to the Joy package example. That is currently possible without any code changes. I updated the PR to instead update the documentation to demonstrate how this can be implemented using the MUI package.

@duynguyen-kun I believe you are wanting to implement something like this:
https://github.com/mui/material-ui/pull/42973/files#diff-5e9f55b9f0c001a9bc86e156849c1ce1b0e52693a47a3e4b8a49a8d6a91665b3

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.