Coder Social home page Coder Social logo

Comments (5)

siriwatknp avatar siriwatknp commented on July 25, 2024 2

I think we can remove it before the stable release of v6. It's a breaking change but I think CssBaseline is used once in a project.

from material-ui.

o-alexandrov avatar o-alexandrov commented on July 25, 2024 1

@oliviertassinari thank you for linking the issue and specifying the point 4. Would you like to reword the 4th point there, so it says removal, instead of setting the value to true by default?

  • if yes, then Iā€™d happily suggest to close this issue as this one would become a duplicate

from material-ui.

oliviertassinari avatar oliviertassinari commented on July 25, 2024

The prop was added to avoid breaking changes, as far as I remember.

This issue looks like point 4 of #38507 but where we also remove the prop.

from material-ui.

headironc avatar headironc commented on July 25, 2024

I'll try completing this.

from material-ui.

chrisbellstardust avatar chrisbellstardust commented on July 25, 2024

There doesnt seem to be much documentation on actually removing props -- after starting this change I realized this isn't really just a code change and more may be needed.

  • Should the existence of the prop from the css baseline component on the docs be removed?

This issue might be "fixed" faster if we just default the enableColorScheme to true and deprecate the prop?

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.