Coder Social home page Coder Social logo

Comments (8)

mbrookes avatar mbrookes commented on July 20, 2024 2

https://source.unsplash.com/random?wallpapers

image

I imagine it's a transient error and will come back...

from material-ui.

zanivan avatar zanivan commented on July 20, 2024 1

Hey @onlinejudge95 nice catch! As @mbrookes said, it seems to be an issue with the Unsplash URL, and hopefully, it'll come back.

Fortunately, this has been fixed on the revamped templates—however, it's only available on the next branch for now. Is it worth adding a fix in the master branch if the Unsplash URL doesn't return @mnajdova @DiegoAndai?

from material-ui.

mnajdova avatar mnajdova commented on July 20, 2024 1

Fortunately, this has been fixed on the revamped templates—however, it's only available on the next branch for now. Is it worth adding a fix in the master branch if the Unsplash URL doesn't return @mnajdova @DiegoAndai?

I would honestly avoid this. If we do this, we will have to update the styled() calls to match the syntax for v5 (I mean the one compatible with ^5.0.0). I honestly do not think it's worth it.

from material-ui.

onlinejudge95 avatar onlinejudge95 commented on July 20, 2024 1

@mbrookes Unsplash team replied that they are not going to fix this API(sources.unsplash.com), and instead want to onboard to a separate API `

@mnajdova then I would suggest any one of these

  • Use the updated Unsplash API
  • Remove the demo
  • Rename the demo

API links

unsplash-api

from material-ui.

onlinejudge95 avatar onlinejudge95 commented on July 20, 2024

@zanivan I did raise the same to the Unsplash team, let's see if they revert, nevertheless v5 is not going to be deprecated and since this is present in the Getting Started section of the doc, I would be in favor of fixing this.

from material-ui.

mnajdova avatar mnajdova commented on July 20, 2024

Use the updated Unsplash API

@zanivan it makes sense to do this

from material-ui.

zanivan avatar zanivan commented on July 20, 2024

Would a static image work instead? I wonder if it's worth using an API just to randomize the wallpaper in the template. Maybe a local static image would be more future-proof, in my opinion.

from material-ui.

onlinejudge95 avatar onlinejudge95 commented on July 20, 2024

It is better to use a local image.

I tried updating the doc with the new API but the Unsplash team has made this an authenticated route now, I don't see the point of integrating an authenticated API just for a template in the demo site.

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.