Comments (6)
Being able to specify the classifier used for attachement would be nice too.
Original comment by [email protected]
on 26 Mar 2009 at 2:43
from onejar-maven-plugin.
Will do.
Original comment by [email protected]
on 26 Mar 2009 at 4:37
- Changed state: Accepted
- Added labels: Type-Enhancement
- Removed labels: Type-Defect
from onejar-maven-plugin.
I have deployed version 1.4.0-SNAPSHOT which should fix this. Please try it.
Add these (optional) configuration parameters to use the feature:
<attachToBuild>true</attachToBuild>
<classifier>yourcustomclassifier</classifier>
Please tell me if it works for you as expected.
/Hugo
Original comment by [email protected]
on 26 Mar 2009 at 4:57
- Changed state: Started
from onejar-maven-plugin.
Wow that was fast ! :-D And it's working well.
As a side note I'd say that that would be nice to have the produced jar in the
target
directory named like the attached artifact.
For example a project with artifactId "test" and the onejar-maven-plugin
configured
with the snipped you provided would have :
- test-1.0-SNAPSHOT.one-jar.jar in the target/ directory
- test-1.0-SNAPSHOT-yourcustomclassifier.jar in the maven repository
It's a very little thingie but I like filename consistency :)
Best Regards
/Paul
Original comment by [email protected]
on 26 Mar 2009 at 5:06
from onejar-maven-plugin.
Thanks!
And yes, I thought about that too when fixing this. I very much agree that we
should
have consistency in how things work and how they are named by default. Since
implementing it to be the default behavior, breaks backwards compatibility with
how
it works now, it will have to wait until 2.0.0.
Please add the request as a separate issue so I don't forget, and I will
milestone it
for 2.0.0.
There is a workaround that I have used so far. Add this to your plugin
configuration:
<filename>${project.build.finalName}-yourcustomclassifier.jar</filename>
<filename> is what the file in target will be called, and <classifier> is for
the
installed/deployed artifact.
BTW, I also released version 1.4.0, so you can use that instead of the SNAPSHOT
now.
Original comment by [email protected]
on 26 Mar 2009 at 6:20
- Changed state: Verified
from onejar-maven-plugin.
Wonderful, using 1.4.0 now. We have a first alpha release for our project using
onejar tomorrow and this comes just in time, thanks again !
I added the request as issue 8.
Original comment by [email protected]
on 26 Mar 2009 at 7:58
from onejar-maven-plugin.
Related Issues (20)
- Artifacts should be copied by user selection (runtime, compile, etc) HOT 4
- Make OneJarMojo.mainJarFilename writeable HOT 2
- using different native libs for different os not working HOT 8
- Local dependency projects are not included in the onejar HOT 2
- upload to central repository HOT 2
- java.io.FileNotFoundException: log4j.xml HOT 6
- Provide override for generated jar file name HOT 1
- Support newer versions of OneJar HOT 3
- Axis2 jar doesnot load
- Use newer version of One-JAR 0.97 HOT 1
- Cant specify JarClassLoader for One-jar, need to because of spring url loading HOT 5
- Add arbitrary manifest entries to top-level
- generic classpath arguments cannot be passed to execution
- Patch for /trunk/src/site/apt/usage.apt
- Can this be used under Java 1.5?
- Enhanchment - support adding one-jar.properties to the target one-jar
- How to Get List of ClassPath Resources in OneJar? HOT 2
- Support system properties included as /one-jar.properties
- NullPointerException thrown trying to access MANIFEST.MF of embedded jars
- How to add class path folder in Manifest
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onejar-maven-plugin.