Coder Social home page Coder Social logo

Comments (6)

danielchalmers avatar danielchalmers commented on May 28, 2024 3

The sizes in the ToggleGroup were changed in #8676 and @henon suggested staking them to the Button sizes for consistency. I said we should explore changing both to a new standard to improve the quality. This issue was opened to let us discuss this idea in a wider context. We need to at least make a decision on the Button and ToggleGroup sizes before v7 is released.

cc @Garderoben @mckaragoz @ScarletKuro @Mr-Technician

from mudblazor.

henon avatar henon commented on May 28, 2024 2

I am all for standardization of sizes. Currently the elements feel like a zoo if you align them next to each other ;).

Off-Topic: Maybe in the process we could aslo finally center the button text vertically. Currently it is slightly off-center (due to the font underline??) which is funny as the button caption is all capitalized. And even if it weren't, it would still look better were it perfectly centered.

from mudblazor.

henon avatar henon commented on May 28, 2024 1

Yes of course the component dimensions will have to shrink accordingly

from mudblazor.

danielchalmers avatar danielchalmers commented on May 28, 2024 1

We need to consider font sizes as well. Button and ToggleGroup (for example) should have the same dimensions AND text size. What does it look like in Material Design 2? That's what we should aim for.

from mudblazor.

danielchalmers avatar danielchalmers commented on May 28, 2024 1

The reason some controls look vertically offset is probably due to the excessive line height in the default typographies:

image

M2

image

from mudblazor.

danielchalmers avatar danielchalmers commented on May 28, 2024

@henon Just to confirm, if the density changes then the dimensions will change with it? Ex: Button 36px, Button Low Margin 34px #8946

from mudblazor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.