linked skills styling about jsonresume-theme-elegant

[mudassir0909]

I'm wondering whether this is the right way to link skills, because if your keywords in itself are markdown formatted, they won't do well with the search(in case we have one in future). Basically your resume won't show up if someone searches for the keyword git or wiki

This could perhaps need a support in schema where you could do something as follows

  "skills": [
    {
      "name": "tools",
      "level": "Master",
      "keywords": [
        {
           "name": "git",
           "url": "http://fr.wikipedia.org/wiki/Git"
        }
      ]
    }
  ]

And theme would ensure each skill if has an url is linked appropriately. You could actually create a new issue on https://github.com/jsonresume/resume-schema

[mudassir0909]

Although for now I can fix the css styling :)

[oupala]

I've juste create a new issue in resume-schema (see above).

In the meantime, I would be pleased if you can take care of the css styling...

[mudassir0909]

@oupala I had forgotten about this, my bad! keywords do not support markdown at the moment, how did you see links?

[oupala]

I see standard skills written in white on a light blue background, and linked skills in dark blue on a light blue background.

You can see that dark blue on a light blue background is not easy to look at. It should be white either, even if it's a link. Maybe a dashed underline could differentiate links from standard non-linked skills.

[mudassir0909]

I understand the concern about the styling which I'll fix but I'm curious on how you got them as links in the first place, because the theme doesn't support markdown for keywords

[oupala]

Well, it does in fact. At least, as far as I can tell.

Here is my json:

    {
      "name": "outils de communication",
      "level": "Master",
      "keywords": [
        "[markdown](http://fr.wikipedia.org/wiki/Markdown)",
        "remark",
        "reveal"
      ]
    },

And level is not rendered.

[mudassir0909]

Are you sure you're directly using this theme via jsonresume & not from hackmyresume or something? Since, I haven't yet implemented markdown support inside the skill keywords because of this

[oupala]

You're right, I'm using hackmyresume.

You mean that hackmyresume is adding features to your theme?

[mudassir0909]

yes, someone must have forked the theme, modified it & added it on hackmyresume. It'll be better if you take this issue to that repository after you find which one it is. Closing this until then.

This theme at the moment is only supposed to support jsonresume

[oupala]

hackmyresume is able to use your theme without needing to be forked. I think we can say that hackmyresume is natively compatible with jsonresume theme.

See my package.json dependencies:

  "dependencies" : {
    "hackmyresume" : "^1.8.0",
    "jsonresume-theme-elegant" : "^1.3.0"
  }

There is still a styling issue on which you can do something. Maybe you can reopen the issue?

[mudassir0909]

Can you please check & confirm that because if you look at the source code I'm not at all processing skills as markdown. So, someone must be doing that, right? can you please look who's doing that?

My suggestion would be to fork this theme, modify as per hackmyresume needs & use it. Since, this is aimed at JSONResume only.

[oupala]

I'm using hackmyresume v1.9.0-beta and this does not work any more. :-(

You say that jsonresume-theme-elegant aims at JSONResume only, but hackmyresume say that they try to be a compatible alternative to JSONResume that offer a local only solution (where JSONResume needs a JSONResume server and an internet access).