Comments (12)
Haven't yet, do you have any pointers, I can work on it during this weekend if you do. Sounds like a good feature. But again, we might then need the ability to use a particular language as a default language. The current resume schema doesn't support theme metadata, it is in talks & might get implemented in the upcoming version of resume schema. Nevertheless, we can implement i18n with English as default language for now.
Also, right now the resume is being rendered by the server so if we were to implement i18n then we might need to go for client side rendering so that we can rerender the whole view when a language has been changed.
from jsonresume-theme-elegant.
I'm a real fan of gettext and there is many implementation of gettext in javascript.
I also think that english should be set as the default language if not explicitly set by the user.
I don't really understand how you imagine implementing i18n without metadata, but I thought it could be on the template side, before the server rendering.
from jsonresume-theme-elegant.
I was thinking of client side i18n implementation. Whenever the user changes the language we can rerender the view, similar to how we do it in Single Page Applications. Thinking in terms of SPA would be overkill & will affect SEO too, it should be rendered on server side with the metadata passed via theme query params, something like http://registry.jsonresume.org/mudassirali?lang=fr
from jsonresume-theme-elegant.
I totally agree with you @mudassir0909 : server side rendering is better. It is also better when you think at static file, which is produced by the export
command.
You should be able to export the resume in a particular language, then upload it somewhere to a web server.
from jsonresume-theme-elegant.
Yep, so let's wait until the next version of the schema is released
from jsonresume-theme-elegant.
Ok.
But can you please explain me why waiting for the next version of the schema would help?
We talked about passing the language as a parameter of the export command. I don't see why we would need some schema metadata.
In your resume, it would mean to translate strings such as:
- background
- about
- work experience
- ...
Did you mean translating the whole resume? I was talking about translating the strings that come from the theme. It could be a good first step while waiting for schema metadata.
Oy maybe we misunderstand each other...
from jsonresume-theme-elegant.
I mean even if you want to translate just the section names, the translated strings should be part of the HTML generated by the theme server. Now, theme server right now just passes resume
as argument for rendering theme, so there is no way to know which language the user has selected, getting me?
Also, it makes sense to translate the entire resume instead of just the heading, because if the section name is in a different language than the content, it's not really useful. For full translation maybe the users should have multiple copies of the resume? something like resume.en.json, resume.fr.json(this discussion could be part of resume-cli repo).
from jsonresume-theme-elegant.
I agree @mudassir0909 the theme server needs to evolve. But I did not catch the link between the theme server and the next version of the schema.
I also agree that we might need full different version of each resume, and maintain multiple copies. I currently have sort of a resume.fr.json but my headings are in english. I would be pleased to be able to translate these headings in french also...
from jsonresume-theme-elegant.
Actually my bad, there is no link. When I said next version of schema, it is supposed to support metadata as part of resume object which theme developers can leverage to enable customisations. Now, in your case you might have the metadata as {lang: 'fr'}
, so theme would render all the section names in french.
As of now, all we can do is implement with english as default language & perhaps add other languages when the schema starts supporting it, makes sense? If it does I'll start working on it when I get some free time.
from jsonresume-theme-elegant.
I think we share the same vision. That's great!
from jsonresume-theme-elegant.
when is coming this feature? :)
from jsonresume-theme-elegant.
@beratcarsi I think to implement this in a theme we might need some changes in the resume schema , more like a language identifier using which the theme could render content in selected language. I guess this will be implemented in next major release of resume-schema. See this issue jsonresume/resume-schema#35
from jsonresume-theme-elegant.
Related Issues (20)
- HTML refers to 2 font files on unpkg.com that are not available HOT 2
- Slow rendering. HOT 6
- Markdown support for skills.keywords
- Dark mode HOT 2
- Project entity instead of company
- Implement "certificates" section HOT 10
- Add level indicator to each language in profile card HOT 3
- Websites links added to the Company description are not visible on Elegant Theme HOT 1
- Profile image link from Dropbox not rendering
- basics.image being ignored / profile photo missing HOT 2
- Adding SlideShare to Social Profiles
- Unable to build HOT 1
- Custom avatar is not loaded into the JSON resume HOT 1
- Telegram support HOT 6
- PDF print improvements HOT 5
- Support Turkish Character HOT 1
- External fonts HOT 4
- Issues running theme on node server 7+ HOT 1
- missing icon HOT 7
- Make the theme printable HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsonresume-theme-elegant.