Comments (4)
How is it broken for you? Changing the scene from Sphere_horosphere to Sphere_plane may help for the other values of r?
from hypvr-ray.
I see, in fragmentInclude.glsl, horosphereSize is hardcoded for the {4,3,6} and planeOffset hardcoded for {4,3,7}. So e.g. Sphere_plane works for the {4,3,7} but gives bad results for the {4,3,8} (pic below). So we'll just need to make those sizes uniforms to pass into the shader. It would probably be nicer for the user to not have separate sphere and plane options, and to default to the correct option depending on the honeycomb.
from hypvr-ray.
Ah I see. In "sphere_plane" the geodesic plane is (I believe) set to give the "head" of the dual cell, no matter what value of p is used. But the sphere radius is hard coded to work reasonably for {4,3,7}. Yes, these should be fed in as uniforms. But what choices should we make for the sphere radius? Is there a natural choice to make?
from hypvr-ray.
This is fixed now, and works well in most all cases. One example where it doesn't work is Sphere_plane doesn't produce goodness for the 436. What I think would be better would be to not have scenes that pick the cutting from a vertex, because we can automatically pick the correct cut (sphere, horosphere, plane) based on the vertex figure. I think I'll open an issue for that.
from hypvr-ray.
Related Issues (20)
- Fix simplex cuts for r = 5, r >= 7 HOT 3
- Select different textures for the concrete effect HOT 1
- Create a version using the THREE effects composer. HOT 1
- Feature Idea: Render boundary-at-infinity for hyperideal honeycombs
- Create a local scene based off of Binary Tiling
- Implement Post Processing using Three.EffectsComposer HOT 1
- Replace the two pass stereo render with one single pass.
- Feature idea: allow capturing frames for video
- Place lights based on honeycomb HOT 2
- Support keyboard roll camera movement HOT 2
- Calculate a max value for the "Edge Thickness" slider
- Option for light brightness to be proportional to amount of visual sphere the light occupies HOT 1
- Fix strange banded lighting behavior for some {p,q,r} values
- In VR have one controller be a light, other be a global sphere object
- Improve initialization speed. HOT 2
- Look into WebGL2
- SteamVR freaks out when VR is enabled. HOT 3
- Possible performance save.
- Shortcut geometric series when ray-marching towards a surface HOT 2
- Question about the scene raymarching HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hypvr-ray.