Trimming quote escaped CSV is not trimming about fast-cpp-csv-parser

[GoogleCodeExporter]

Trimming happens before unquoting. In the following I will replace spaces with 
_ for clarity.

Consider the following CSV-row:

"a",_"_b",_c 

There are several ways to read this data. The variants supported by the current 
code are the following:

Option 1: No unquoting, no trimming
1st = "a"
2nd = _"_b"
3rd = _c

Option 2: no unquoting, trimming
1st = "a"
2nd = "_b"
3rd = c

Option 3: unquoting, trimming
1st = a
2nd = _b
3rd = c

Option 4: unquoting, no trimming
1st = a
2nd = _"_b"
3rd = _c

What you want is another variant that is currently not directly supported:

Option 5:

1st = a
2nd = b
3rd = c

My feeling is that option 3 is more natural than option 5 as the CSV 
specifically encloses the space in the quotes. Further changing this might 
break existing code that relies on the current behavior. 

You can get pretty close to option 5 using the current code:

void my_trim(char*&str){
  while(*str == ' ')
    ++str;
  char*back = str+std::strlen(str);
  while(back != str && *(back-1) == ' '){
    --back;
    *back = '\0';
  }
}

...

char*str;
while(in.read_row(str)){
  my_trim(str);
  // do with str what you want.
}

I prefer this to adding yet another template parameter for "trimming after 
unquoting".

Original comment by [email protected] on 28 Sep 2014 at 1:55

• Changed state: Done