WINEPATH does not include necessary directories about msvc-wine

[mstorsjo]

In the tool wrappers, there are two sources of WINEPATH enviroment variables, but both may cause problems:

1. For nmake, the WINEPATH comes from BINDIR.
   To my understanding, SDKBINDIR should also be included. Otherwise, nmake cannot correctly find rc. You can try to compile putty to regenerate an error that complains about missing rc.

Yes, this is true

2. For other wrappers, the WINEPATH is exported in msvcenv.sh and is set to $MSVCDIR\bin\Hostx64\x64
   This directory is fixed to Hostx64\x64 regardless of which arch we are targeting. To the best of my knowledge, the folder should depend on the target arch, and it is better to use original directories (SDKBINDIR and BINDIR) instead of the wrapper directories in case that some other exes and dlls are required.

No, this part is actually intentionally the way it is.

For older MSVC versions (2017), the cross compiler dirs (e.g. Hostx64/arm64, or anything other than x64) is missing a bunch of DLLs, e.g. mspdbcore.dll and msvcdis140.dll. So whenever running tools from Hostx64/whatever, Hostx64/x64 is expected to be in the path. Same thing if Hostx86/whatever is used, then Hostx86/x86 would have to be available in the path, for those DLLs to be found.

But I do see that this does conflict a bit with the nmake case. I'd suggest keeping the Hostx64/x64 case last in the path, but adding SDKBINDIR and BINDIR in front of it probably is good.

[Cryspia]

Thanks for the explanation, the pull request branch has been updated accordingly.

[mstorsjo]

This should have been fixed by 438ae37.