Ribbons about pokesprite

[msikma]

I already got started on this myself. Fetching the ribbons isn't a difficult task. This data is from Bulbapedia. But I'm still going to check if I can get a cleaner copy that doesn't have trimmed images.

[route1rodent]

@coltongit hmm that's what he said, you repeated the same... but if you mean that you are willing to contribute pls feel free to open a pull request with your proposal.

otherwise... please avoid these kind of comments. note that every people in this thread get an email or notification or both every time someone comments!

[rawr51919]

Alright. I'll get to it. Will try using Bulbapedia for them as msikma wanted to do

[msikma]

Unfortunately, this only contains a handful of the newer ribbons. We need a full list of the old ribbons to be able to display any kind of legal ribbon that a Pokémon may carry.

The trimming is a problem because, take this one for example. It's 30x31 pixels. It was originally 32x32 pixels. That means when I expand it back to 32x32 I'm not sure if it's supposed to get 2 pixels up and 1 down, or 1 pixel up and 2 down. (And if they're trimmed, I don't know what other processing might have been done to them.)

But I'm thinking it might not be such a big deal after all. I could possibly just figure it out manually.

[msikma]

Ribbons are now merged: https://msikma.github.io/pokesprite/overview/misc.html

[msikma]

That's a very good point. I'll do some research into this, to see where I can find the ripped ribbon icons from ORAS. (I've got some, but I'm not sure if my collection is complete.)

[msikma]

Pretty sure this is a complete XY dump, but I'll still need the ORAS ones.

[itsjavi]

I found them here, not sure if they are complete though

• X/Y
• OR/AS
• Sun/Moon

In Bulbapedia they seem to have a full list

[route1rodent]

I found another resource for ribbons here, in the PKHeX project: https://github.com/kwsch/PKHeX/tree/master/PKHeX.WinForms/Resources/img/ribbons

which I integrated in my pokedex project and gave them proper names: https://github.com/capsulemonsters/pokedex/tree/master/src/assets/icons/ribbon

They contain all the ribbons from Gen 3 to Gen 7, including ORAS

[rawr51919]

Will the ribbons be added in soon?

[itsjavi]

also now in gen 8 they are in higher resolution, I think they are not pixel art anymore

[rawr51919]

also now in gen 8 they are in higher resolution, I think they are not pixel art anymore

Wonder which Gen we should use for the ribbons, in that case

[itsjavi]

I hope we could have both, because some of them don't exist anymore on new gens

[msikma]

I'm planning on introducing ribbons to PokéSprite after the Gen 8 update is done. I'm going to see if I can get a clean dump from the games, because all ribbons I'm able to find online have been modified, as they've had empty space trimmed out.

If not I'll probably get them from Bulbapedia because that way I can easily extract all the required meta-information too (name, original game, Japanese title, etc.)

[rawr51919]

Since the Gen 8 update is out, now's the time to work on getting ribbons to pokesprite.

[rawr51919]

The Bulbapedia images could probably be used first. We can deal with getting ingame rips of everything later. Good to see that the code side of things is getting implemented too

[route1rodent]

in which way are they trimmed? could this work for you? https://www.spriters-resource.com/fullview/123711/
it needs slicing though

[rawr51919]

Unfortunately, this only contains a handful of the newer ribbons. We need a full list of the old ribbons to be able to display any kind of legal ribbon that a Pokémon may carry.

The trimming is a problem because, take this one for example. It's 30x31 pixels. It was originally 32x32 pixels. That means when I expand it back to 32x32 I'm not sure if it's supposed to get 2 pixels up and 1 down, or 1 pixel up and 2 down. (And if they're trimmed, I don't know what other processing might have been done to them.)

But I'm thinking it might not be such a big deal after all. I could possibly just figure it out manually.

Something to rectify when the ingame rips happen

[msikma]

I've done a little bit of preliminary work, see PR #59.