Coder Social home page Coder Social logo

Usability about pokesprite HOT 10 CLOSED

msikma avatar msikma commented on May 18, 2024 2
Usability

from pokesprite.

Comments (10)

arcanis avatar arcanis commented on May 18, 2024 1

I went ahead and made a fork: https://github.com/arcanis/pikasprite

Let me know if you're interested into merging the efforts somehow!

from pokesprite.

rawr51919 avatar rawr51919 commented on May 18, 2024 1

Is this still being worked on?

from pokesprite.

rawr51919 avatar rawr51919 commented on May 18, 2024 1

OK. Since this has been resolved by the Gen 8 update, this issue can therefore be closed.
@arcanis, you can do the honors if you'd like

from pokesprite.

msikma avatar msikma commented on May 18, 2024 1

@route1rodent thanks for your offer to help. I'm closing this issue for now. I'm planning to start working on a CSS generator for this sometime soon, probably next weekend. My plan is to make one in Node that generates static files (the static files will then be a separate npm package). It'll be simpler than the earlier version, which was complicated and used JS because back in 2014 browser support was terrible (they refused to accept that many CSS rules).

from pokesprite.

msikma avatar msikma commented on May 18, 2024

Sorry, somehow I missed this entirely until now!

You're entirely right, the way the project is set up right now is not very useful. The code is actually extremely old, and by the time I first released it there was no other way to get it to work properly except by using JS. The latest Internet Explorer at the time simply refused to accept that many CSS rules and ceased to work properly, and using pure CSS was actually less efficient even in better browsers. Today the situation is different and we can and should totally do it that way.

I'm currently working on a complete revamp as a Node project, although the truth is I think most people are really here for the icons as individual files. I'm not sure that this repo even needs to have a script for generating an icon sprite—maybe it should just be a set of icons, and the image/CSS generation should be somewhere else. That's how I would do it today if I were starting this from scratch, and really main reason I'm still thinking of making a new script is because the repo history just happens to already have code in it. 🙂

So your new script is very welcome and I'll have a look at it more closely when I've got some time, hopefully sometime next week.

from pokesprite.

msikma avatar msikma commented on May 18, 2024

@arcanis Hi there, I'm about to release a new version with Gen 8 support. It's been modified quite a bit to make it easier to do future updates. I've also decided to remove the sprite generation from this repo to a separate project, so this repo will only contain sprite files and JSON files needed to use them.

I'm planning on making a new spritesheet generator in Node myself as well (which will take a bit more time), but I wanted to let you know about this upcoming update in case you're also still interested in updating your repo.

from pokesprite.

msikma avatar msikma commented on May 18, 2024

Gen 8 has just landed, so the new data files are available if you ever feel like working on an update of PikaSprite. 🙂

from pokesprite.

route1rodent avatar route1rodent commented on May 18, 2024

@msikma I could help you with the sprite generator I have experience doing that already with imagemagick. maybe we can find some nice npm module for imagemagick that could help.

so I am up for contributing on this. maybe pokesprite should stay only as the resources project
and then having a pokesprite-css project (or whatever name) that will be exaclty that: a sprite and a CSS generator (SASS too) that doesn't require JS to work. pokesprite would be an npm dependency of that project.

we could even have separated set of sprites (items and pokemon) since not every project is interested in the whole sprite sets.

so if you start a project feel free to poke me and let's organize the work in the "Projects" section of the repository. You can find me a twitter if you want to talk about this: @ route1rodent

and then we can close this issue.

from pokesprite.

rawr51919 avatar rawr51919 commented on May 18, 2024

@route1rodent If you want to go that route, procedural Spinda spots could be useful, as Spinda by nature have completely random spots (the groundwork for which being covered by PR #56 and issue #26)

from pokesprite.

route1rodent avatar route1rodent commented on May 18, 2024

@coltongit I think that needs separate attention because that has nothing to do with this issue or generating a CSS sprite sheet out of the existing pokesprite icons.

I commented in those issues themselves about my opinion about spinda

from pokesprite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.