Coder Social home page Coder Social logo

Comments (3)

casperisfine avatar casperisfine commented on September 27, 2024

Thanks, I'm able to repro and I'll dig into this.

from msgpack-ruby.

casperisfine avatar casperisfine commented on September 27, 2024

Ok, so the bug is here:

frame #3: 0x0000000101cf190c msgpack.bundle`object_complete_ext(uk=0x0000600003e15200, ext_type=0, str=8) at unpacker.c:180:43
   177 	static inline int object_complete_ext(msgpack_unpacker_t* uk, int ext_type, VALUE str)
   178 	{
   179 	    if (uk->optimized_symbol_ext_type && ext_type == uk->symbol_ext_type) {
-> 180 	        return object_complete_symbol(uk, rb_str_intern(str));
   181 	    }
   182 	
   183 	    int ext_flags;

str=8 means str is nil. I think there is a logic bug because extension strings can be nil and we don't deal with that.

from msgpack-ruby.

casperisfine avatar casperisfine commented on September 27, 2024

Test case reduced to:

require 'msgpack'
codec = MessagePack::Factory.new
type_attributes = {
  code: 0,
  packer: Symbol.method_defined?(:name) ? :name.to_proc : :to_s.to_proc,
  unpacker: :to_sym.to_proc,
  optimized_symbols_parsing: true,
}
codec.register_type(
  type_attributes.fetch(:code),
  Symbol,
  type_attributes
)

pp codec.load(codec.dump(:"")) # This should give the seg fault.

from msgpack-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.