createWriteStream in recent release may have encoding issue (more bytes written than sent) about ssh2

[ppayne]

I have tested against the history of SFTPv3.js and can confirm commit 2081bff was WORKING, and commit 538e9e7 FAILED.

[brandonramirez]

I am seeing this behavior as well. Uploading a tarball results in a destination file exactly double the size of the source. Needless to say, untar does not like the file.

[brandonramirez]

As @ppayne indicated, commit 538e9e7 is definitely the root cause. I have found the bug.

In WriteStream.prototype.write, line 1753, this.pos is incremented by the size of the latest buffer chunk. Then it calls this.flush(). In commit 538e97, flush was changed to also increment this.pos by the data length when sftp.write is the method being used. Therefore, there is a double-increment, causing the file to be exactly double.

Removing line 1700 from SFTPv3.js resolves this problem.

I can supply a patch.

[mscdex]

Also: I'm currently in the process of switching over all streams1 code to streams2, which should simplify/fix a lot.