What is the correct way to close a sftp session? about ssh2

[mscdex]

If you want to copy multiple files, don't call sftp.end();. You don't even have to wait for a file copy to finish before starting the next one.

Also: calling ws.end(); in your ReadableStream's 'end' handler is unnecessary since pipe() already takes care of all that.

Here's all you should need if you want to go the stream piping route:

c.sftp(function(err, sftp) {
  if (err) throw err;
  var files = ['.bashrc', 'test.sh',
               'remotefile2', 'localfile2',
               'remotefile3', 'localfile3'],
      left = files.length / 2;
  for (var i = 0; i < files.length; i += 2) {
    var rs = sftp.createReadStream(files[i]),
        ws = fs.createWriteStream(files[i + 1]);
    ws.on('finish', function() {
      if (--left === 0) {
        console.log('SFTP :: All files transferred!');
        c.end();
      }
    });
    rs.on('error', function(err) { console.log('rs: ' + err); });
    rs.pipe(ws);
  }
});

If you have large files, you might benefit from parallel reads. In those cases you might want to use fastGet():

c.sftp(function(err, sftp) {
  if (err) throw err;
  var files = ['.bashrc', 'test.sh',
               'remotefile2', 'localfile2',
               'remotefile3', 'localfile3'],
      left = files.length / 2;
  for (var i = 0; i < files.length; i += 2) {
    sftp.fastGet(files[i], files[i + 1], function(err) {
      if (err) throw err;
      if (--left === 0) {
        console.log('SFTP :: All files transferred!');
        c.end();
      }
    });
  }
});

[bnoon]

Great. Thanks for the help. I have it working now. Is there any case that you would call sftp.end()?

I will generally need to stream the files serially, but from multiple hosts (in parallel).

[mscdex]

Usually there is no real reason to end the sftp subsystem, you can always re-use it later.