Coder Social home page Coder Social logo

Comments (4)

mscdex avatar mscdex commented on May 20, 2024

Ok, this should be fixed in the master branch -- an error event will be emitted. Note that I've also changed the 'end' event for Dicer to 'finish' to keep in line with the documented events for a Writable stream.

from dicer.

golyshevd avatar golyshevd commented on May 20, 2024

Thank you! It works! And another similar issue. If Readable stream emits an error, I expect that dicer Writable will stop parsing and emit this error on themself instance and should not emit 'finish' if any 'error' event emitted

from dicer.

mscdex avatar mscdex commented on May 20, 2024

@golyshevd I looked at Writable's code in node core while I was working on this and from what I can tell 'finish' is still emitted even when 'error' is emitted. So I was trying to keep that same behavior.

from dicer.

golyshevd avatar golyshevd commented on May 20, 2024

hm, surprising, anyway, thanks!

from dicer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.