Coder Social home page Coder Social logo

Comments (5)

ooeygui avatar ooeygui commented on July 17, 2024

Can you supply information as to why it is needed?

from remote-wiring.

turkycat avatar turkycat commented on July 17, 2024

Firmata.cpp calls it "startSysex" / "endSysex" while I named it "beginSysex" / "endSysex" in UwpFirmata. I agree that it should have matched the latter, but not sure if we should change it now?

from remote-wiring.

zfields avatar zfields commented on July 17, 2024

We are trying to provide a familiar API surface, so we should at least have parity. I would take the logic from beginSysex(), move it startSysex(), then have beginSysex() call startSysex() and deprecate beginSysex().

from remote-wiring.

turkycat avatar turkycat commented on July 17, 2024

We should revisit this issue. New UwpFirmata implementation does not use startSysex() or endSysex(). New function signatures are:

[Windows::Foundation::Metadata::DefaultOverload]
void
sendSysex(
        SysexCommand command_,
        IBuffer ^buffer_
    );

and

void
    sendSysex(
        uint8_t command_,
        IBuffer ^buffer_
    );

which allow the entire IBuffer to be sent at once. No more need to invoke 3 functions for one concept. It does not perfectly match the Firmata API (as this issue was meant to resolve) but is arguably more sensible on our platform.

from remote-wiring.

zfields avatar zfields commented on July 17, 2024

I'll close this issue. The original observation is no longer valid.

from remote-wiring.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.