Retore totally fails about open-android-backup

[mrrfv]

These files definitely shouldn't be there. The only explanation I can give you is that you've probably entered a directory as the location of the backup archive, causing 7-Zip to extract every single file in the folder. From what I can tell, these odd files you are seeing are the contents of linux-android-backup-companion.apk.

I need some more information before writing the fix - when the script asked you for the location of the backup archive, what did you enter?

[knghtbrd]

In both the backup and restore cases, I entered . for the location. In the extraction case, because it was suggested as a default (and because I had created a Dir and run the script from it seeing the usage of the script to backup) Joseph

…

On Sun, Jul 3, 2022, at 07:08, mrrfv wrote: These files definitely shouldn't be there. The only explanation I can give you is that you've probably entered a directory as the location of the backup archive, causing 7-Zip to extract every single file in the folder. From what I can tell, these odd files you are seeing are the contents of `linux-android-backup-companion.apk`. I need some more information before writing the fix - when the script asked you for the location of the backup archive, what did you enter? -- Reply to this email directly or view it on GitHub: #14 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>

[mrrfv]

You need to provide the full location to the backup archive (in your case, it should be ~/Source/linux-android-backup/asuna/linux-android-backup-06-30-2022-12-15-45.7z) if you're restoring it.

[knghtbrd]

Good to know, thanks. Might I suggest checking for a directory and looking to see if there are backup files in it and presenting a list the same way you do for the backup/restore menu? I think you should be detecting whether the supplied restore location is not an archive at least, but it seems like you have some option to do something cooler than that. Joseph

…

On Sun, Jul 3, 2022, at 11:20, mrrfv wrote: You need to provide the full location to the backup archive (in your case, it should be `~/Source/linux-android-backup/asuna/linux-android-backup-06-30-2022-12-15-45.7z`) if you're restoring it. -- Reply to this email directly or view it on GitHub: #14 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>

[mrrfv]

Scanning for backups would definitely be cool, but for most users it would be impractical (for example, if they want to simply drag and drop the archive from a file manager or the backups are stored in a remote location, like a NAS or cloud storage). A simple check whether the specified location is a file should do the trick without complicating things too much.