Coder Social home page Coder Social logo

Comments (15)

mrliptontea avatar mrliptontea commented on September 28, 2024

Hi,

I need more information.

Missing icons:

  • What version of Redmine do you have?
  • Does this occur everywhere or only on specific pages? On the screenshot, I see some icons are visible.
  • Do you use any plugins which might alter styling and break the icons?

Translations:

  • Inspect the source, check what's the value in <html lang=""> attribute
  • In devtools console, paste document.documentElement.lang and see what it returns.

from purplemine2.

abrochet avatar abrochet commented on September 28, 2024

Hello,

Thank you for your reply.

Missing icons:
• What version of Redmine do you have?
• Do you use any plugins which might alter styling and break the icons?

The information below (version of redmine / plugin ):

image

• Does this occur everywhere or only on specific pages? On the screenshot, I see some icons are visible.
For the moment the error has been detected on the edition page of tickets. (Adding Observer / editing comments / deleting comments etc.)

Translations:
• Inspect the source, check what's the value in <html lang=""> attribute
I did not find any attribute: <html lang=""> sorry.

• In devtools console, paste document.documentElement.lang and see what it returns.
Sorry how do I use the devtools console?

from purplemine2.

mrliptontea avatar mrliptontea commented on September 28, 2024

Hi,

To open the devtools console in Google Chrome/Opera, open Redmine and press Ctrl+Shift+J (Windows / Linux) or Cmd+Opt+J (Mac). Then copy and paste said code and hit enter.

image

from purplemine2.

abrochet avatar abrochet commented on September 28, 2024

Ok, thanks.

The result:

image

Thank you for your help.

from purplemine2.

mrliptontea avatar mrliptontea commented on September 28, 2024

Ok, so fr key in the code should work.
Did you run the following commands?

npm install grunt-cli -g
npm install
grunt

from purplemine2.

abrochet avatar abrochet commented on September 28, 2024

No. The commands running under windows server?

from purplemine2.

mrliptontea avatar mrliptontea commented on September 28, 2024

JavaScript is concatenated and minified. The file(s) you modified is not used directly in Redmine; you have to run grunt for your changes to take effect.
Please read https://github.com/mrliptontea/PurpleMine2#how-to-customize-it

Or you can just send me French translations; I'll be happy to add them.

from purplemine2.

abrochet avatar abrochet commented on September 28, 2024

It's doesn't work, the result command:

image

The translations :

- File MenuCollapse.js
topMenuToggler: 'Développer / réduire le menu principal'

- File HistoryTabs.js
all: 'Tout',
notes: 'Commentaires',
details: 'Changements'

- File SidebarToggler.js
toggler: 'Réduire la barre latérale'

I would like to be able to make it works myself because my team would also like to change the menu order :
All / Notes / Changes to Notes / Changes / All

from purplemine2.

mrliptontea avatar mrliptontea commented on September 28, 2024

The file was created, so it worked.

Running "uglify:theme" (uglify) task
>> 1 file created.

You can test in C:\Test\PurpleMine2\javascripts\theme.js if it contains your changes, e.g. by running

C:\Test\PurpleMine2> find "Changements" javascripts\theme.js

Now make sure that this file is uploaded to your Redmine server under
[Redmine installation]/public/themes/PurpleMine2/javascripts/theme.js path.

from purplemine2.

abrochet avatar abrochet commented on September 28, 2024

It's good for me. Thank you very much :)

The images are not missing on our redmine version 3.2.0 we have the same plugins on both redmine. I think there is an incompatibility with version 3.3.0.

Do you have a solution please?

from purplemine2.

mrliptontea avatar mrliptontea commented on September 28, 2024

Ha, you closed the issue when I finally got some time to check the icon problem.
I did few amends to force styles which were overridden by RM+ plugins, namely their a_common_libs.

from purplemine2.

abrochet avatar abrochet commented on September 28, 2024

Hello,

We don’t have the problem on our two other redmine yet we have the same plugin.
I ran a test with the 3.3 version of redmine I didn't encounter the problem anymore so we will migrate our 3 redmine to the latest version.

Thank you for your time.

By the way your plugin is really great.

from purplemine2.

mrliptontea avatar mrliptontea commented on September 28, 2024

Thank you for your appreciation 😄

That's right because the icon-only class, which was overridden, was introduced in Redmine 3.3, and in earlier versions wasn't present anywhere in templates. Also, tabs styles were a little off with these plugins, so I made sure PurpleMine takes precedence.

from purplemine2.

abrochet avatar abrochet commented on September 28, 2024

Hello,

I keep you informed of the migration of our Redmine. You were right the problem came from the a_commons-libs plugin. I identified the part of the code which was a problem.

.icon-only { background-position: 0 50%; background-repeat: no-repeat; padding-left: 16px; } a.icon-only { display: inline-block; width: 0; height: 16px; overflow: hidden; padding-top: 0; padding-bottom: 0; font-size: 8px; vertical-align: text-bottom; }

However we had to stop at the 3.3.2.stable.16261 version because in 3.3.3 version your theme has some problems.

When an update of your theme will be available it will be installed willingly but at the moment all the plugins are not yet compatible for version 3.3.3.

Best regards.

from purplemine2.

mrliptontea avatar mrliptontea commented on September 28, 2024

Hi,

I don't really update this theme unless someone reports an issue as I don't use Redmine anymore.
Can you be more specific about what problems you experienced in? I didn't test it extensively but I haven't noticed anything being unusable in Redmine 3.3.

from purplemine2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.