Coder Social home page Coder Social logo

Comments (5)

mrlesmithjr avatar mrlesmithjr commented on June 12, 2024

/cc @markgoddard @zoobert and anyone else who'd like to review these changes. A lot of work @Tcharl has done here.

from ansible-manage-lvm.

Tcharl avatar Tcharl commented on June 12, 2024

Yes, I thought to make a fork at first: I had some additional features on top of it, but then decided to give back the original code.

This roles has been very useful to me so you totally owe it :-).
I hope you'll enjoy 5 star lint results on Ansible galaxy as well as some additional CI and automated tests. I'll also contribute back the fully automated ci (with integration tests) while I succeed to make it work with github actions or travis.

from ansible-manage-lvm.

Tcharl avatar Tcharl commented on June 12, 2024

Hi,

I tried all my best for CI and molecule, but unfortunately, it won't be possible.
The good news is that it will only be impossible for LVM related roles and possible for the others.

For container-friendly roles, it can be achieved using github actions, see this one for example

For the others, you can use travis molecule-vagrant and vagrant-libvirt can be used: https://github.com/OsgiliathEnterprise/ansible-volumes The bad news being that travis (or vagrant-libvirt) being incompatible with vagrant-persistent-storage, thus not mounting the harddisk to execute lvm tests onto...

from ansible-manage-lvm.

mrlesmithjr avatar mrlesmithjr commented on June 12, 2024

No worries on this. All of my roles are over time getting refactored using https://github.com/mrlesmithjr/cookiecutter-ansible-role which includes all CI/molecule testing. Latest versions of Molecule don't support Vagrant anyways, or at least the last time I checked. Again, thanks for your contribution.

from ansible-manage-lvm.

mrlesmithjr avatar mrlesmithjr commented on June 12, 2024

I see you referenced this https://github.com/ansible-community/molecule-vagrant. Haven't seen this yet.

from ansible-manage-lvm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.