Coder Social home page Coder Social logo

Comments (3)

Tjitse-E avatar Tjitse-E commented on August 11, 2024 3

I've also debugged this problem further:
In vendor/magento/module-catalog/Model/Product/Link/SaveHandler.php:62 all the product relations are deleted (one relation per execute), and then later the links are re-added here:

        // Build links per type
        $linksByType = [];
        foreach ($entity->getProductLinks() as $link) {
            $linksByType[$link->getLinkType()][] = $link;
        }

Only without our custom product links. A quick dirty solution would be to override the execute method via a preference, and them exclude deletion of the custom product link types like this:

        $link = $entity->getData($this->metadataPool->getMetadata($entityType)->getLinkField());
        if ($this->linkResource->hasProductLinks($link)) {
            /** @var \Magento\Catalog\Api\Data\ProductInterface $entity */
            foreach ($this->productLinkRepository->getList($entity) as $link) {

                // Custom modification to prevent deletion of custom link types
                if($link->getLinkType() === ProductLinks::TYPE_NAME) {
                    continue;
                }
                $this->productLinkRepository->delete($link);
            }
        }

I do not yet understand why it is needed to delete all the product links, and re-add them after this. Maybe to prevent duplicate product links?

from boolfly_productrelation.

Tjitse-E avatar Tjitse-E commented on August 11, 2024

I've got the same issue on a Magento 2.2.6 store

from boolfly_productrelation.

Aquive avatar Aquive commented on August 11, 2024

Is this issue fixed?

from boolfly_productrelation.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.