Coder Social home page Coder Social logo

Comments (8)

sciecode avatar sciecode commented on June 14, 2024 2

I was able to reproduce now, the issue can occur if both left/right buttons are pressed simultaneously. The controls becomes stuck as explained by this issue. I'll investigate ways to solve this behaviour, thanks for reporting.

from three.js.

wnr avatar wnr commented on June 14, 2024 1

I think this issue should be treated separately as it is much easier to fix than #24566. I believe that reverting https://github.com/mrdoob/three.js/pull/27425/files would fix this particular issue, but of course it would be preferable to keep it while fixing this regression somehow.

I too use a magic mouse. I notice that it is really easy to reproduce like 75% of the times, but sometimes I can't reproduce it a few times in a row. Very strange. Does this video help?

Kapture 2024-02-14 at 15 45 05

from three.js.

wnr avatar wnr commented on June 14, 2024 1

Can you make a test if Firefox and/or Safari shows the same behavior?

I tried both of them and I'm unable to get the controls stuck (the root issue) so I think this is a Chrome-only issue.

from three.js.

Mugen87 avatar Mugen87 commented on June 14, 2024

Can we merge this issue into #24566? The root cause of both issues seems to be identical.

Sidenote: I still can't reproduce any pointerup related issues on macOS with latest Chrome and a magic mouse. I'll try to reproduce the issue with a different mouse later.

from three.js.

Mugen87 avatar Mugen87 commented on June 14, 2024

/cc @sciecode

from three.js.

Mugen87 avatar Mugen87 commented on June 14, 2024

Can you make a test if Firefox and/or Safari shows the same behavior?

from three.js.

sciecode avatar sciecode commented on June 14, 2024

Unable to reproduce on Windows - FF/Chrome, and Ubuntu - FF/Chrome.

from three.js.

sciecode avatar sciecode commented on June 14, 2024

Although I can't reproduce, I can definitely say there's something inconsistent happening either with user agent or magic mouse hardware.

There are two things that shouldn't occur, judging from the reported error. The block that triggers the error is on OnPointerUp.

case 1:
const pointerId = pointers[ 0 ];
const position = pointerPositions[ pointerId ];
// minimal placeholder event - allows state correction on pointer-up
onTouchStart( { pointerId: pointerId, pageX: position.x, pageY: position.y } );

  • Specifically the case where one pointer is lifted and one pointer remains active. However, I'm unaware of anyway this would happen on a mouse interface. So, this is problematic already.

  • Furthermore, the error implies the saved pointer-position, that is still in contact with the canvas, has undefined coordinates, which should also never happen.

I suspect this isn't an issue on our end, but would need more information of the events and pointerIds/positions to confirm.

from three.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.