Comments (3)
I think adding a field to Object.prototype is extremely bad form and of course error prone in all kinds of other contexts outside of this project. I don't think we should encourage it by accommodating the practice in three.js
from three.js.
Have you done performance tests? I think Object.keys()
is slower than the current code and the current code needs to run many times per second.
from three.js.
Have you done performance tests?
Not at all, that would also be a good reason not to do this. (In fact, we’re still using for…in
in our own code, quite possibly on some hot paths.)
from three.js.
Related Issues (20)
- Some model bounding boxes and the size mismatch problem of the model itself HOT 4
- Typescript - CSS2DRenderer, CSS3DRenderer does not inherit from Renderer HOT 3
- 成功上传一个模型后,会发现它的颜色不见了,变灰了 HOT 3
- GLTFLoader min/max accessor implementation HOT 1
- Alternate GroundProjectedSkybox HOT 4
- Regression: Nodes not working anymore in r160
- WebGLRenderer: warn on invalid or unsupported texture filtering HOT 3
- Shader rendering black pixels on Mac M2 HOT 1
- Modifying the position of the scene can cause misalignment of the SpotLight and SpotLightHelper positions HOT 2
- anisotropy effect looks not that correct HOT 4
- Is it possible to add a setColorAt method for BatchedMesh? HOT 3
- OrbitControls: Infinite Return of getZoomScale When window.devicePixelRatio < 1 HOT 2
- MaterialX: Default input values not being specified results in errors every frame HOT 1
- SVGLoader pointsToStroke incorrect UV mapping when texture applied HOT 2
- WebGPURenderer: Resize breaks post FX setup in `webgpu_rtt` example HOT 1
- Addons.js is incomplete
- Points rendering glitch in iOS Safari HOT 5
- bug in Audio.js setDetune HOT 3
- THREE.BufferGeometryUtils.mergeAttributes fails to merge LineGeometry HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from three.js.