libmpv with lua: leaking memory with each new mpv instance about mpv

[Dudemanguy]

Without bothering to check if there's any leak for me, here are the related looking commits in that timeframe if anyone wants to look into it.

fd3caa2
1e78025
a67bda2

[wbtcpip2]

i opened several issues on this subject ... the problem is real and you always close without investigations ... it leaks approx 1 MB at each instance

#9860

[Dudemanguy]

Oh so actually I can confirm this happens but it's only with luajit. That would explain why people in the old issue couldn't reproduce it reliably.

[kasper93]

Does it also happen if you compile luajit with -DLUAJIT_USE_SYSMALLOC, they have their own allocator. I don't know the details, but maybe it doesn't release memory right away, and this is what you see.

[Dudemanguy]

maybe it doesn't release memory right away

Did not try messing with luajit yet, but this is almost certainly what is happening. ASAN doesn't report any leaks.

[wbtcpip2]

is this related to our topic?
LuaJIT/LuaJIT#1179

[Dudemanguy]

is this related to our topic?

Unfortunately I am using luajit from git master which includes the fix for that issue and the problem still occurs.

Does it also happen if you compile luajit with -DLUAJIT_USE_SYSMALLOC,

Unless I'm doing it wrong, yeah it still happens with this.
My bad, wrong compile. It indeed doesn't happen with that flag.

[wbtcpip2]

is it possible to use the flag -DLUAJIT_USE_SYSMALLOC with the official win release of libmpv? do we have to ask it to shinchiro?

[kasper93]

Will be fixed by #14457

[wbtcpip2]

hello, could you please reopen this issue?

#14457 has fixed the memory leak but after this commit there is 1 leak handle at each new mpv instance (that was not present before the #14457 )

@kasper93 could you please check if in your commit there is an handle that is not closed?

[a10r]

Thanks for the quick fix! Can confirm that the leak is gone in the latest zhongfly build.