Coder Social home page Coder Social logo

Tone map V-Log to PQ HDR about mpv HOT 7 CLOSED

AndrewKeYanzhe avatar AndrewKeYanzhe commented on June 16, 2024
Tone map V-Log to PQ HDR

from mpv.

Comments (7)

Akemi avatar Akemi commented on June 16, 2024

This will utilise Apple's Extended Dynamic Range feature on macOS.

this is completely unrelated to your feature request btw. EDR support can already be utilised by both supported macOS backends.

also aren't you just looking for --target-prim= and --target-trc=?

from mpv.

AndrewKeYanzhe avatar AndrewKeYanzhe commented on June 16, 2024

I tested mpv again with a standard PQ HDR video, and couldn't figure out how to enable EDR.

I am using this config:

autofit-larger=100%x100%

loop-file=inf
--target-prim=bt.2020
--target-trc=pq
--icc-profile-auto
--target-colorspace-hint

--vo-gpu

The video is still tone mapped to SDR. Movist Pro can play the same video in EDR, so the file itself has no issues.

output.txt

Could you help me with this? Thanks!

from mpv.

Akemi avatar Akemi commented on June 16, 2024
  • it's vo=gpu (not vo-gpu)
  • if you want to use target-colorspace-hint use vo=gpu-next
  • if you intended to use libmpv, as in your log, you also have to set the appropriate cocoa-cb-output-csp= option manually (this is only in master for now)
  • icc-profile-auto and the target-* are mutually exclusive, so don't set it
  • update your mpv to the latest version
[   0.000][e][cplayer] Error parsing option vo-gpu (option not found)

from mpv.

AndrewKeYanzhe avatar AndrewKeYanzhe commented on June 16, 2024

I have updated my config as

autofit-larger=100%x100%
loop-file=inf

--target-colorspace-hint

--cocoa-cb-output-csp=bt.2100-pq

vo=gpu-next

When I launch MPV, the "Drop files to play here" window no longer appears. When I open a file using the menu bar, MPV crashes.
output.txt

I am using the latest build by stolendata, mpv-0.37

from mpv.

Akemi avatar Akemi commented on June 16, 2024

there is no crash. mpv just can't initialise a vo, because you are not using the latest version with all features enabled.

[   0.060][v][vo/gpu-next/libplacebo] Failed creating instance: VK_ERROR_INCOMPATIBLE_DRIVER
[   0.060][v][vo/gpu-next/libplacebo] Failed initializing vulkan instance
[   0.060][e][vo/gpu-next] Failed initializing any suitable GPU context!
[   0.060][f][cplayer] Error opening/initializing the VO window.

you can try the latest nightly builds at the bottom (Artifacts) here.

from mpv.

AndrewKeYanzhe avatar AndrewKeYanzhe commented on June 16, 2024

Thanks, I used the latest nightly build and tone mapping of V-Log into EDR works now.

The only issue now is that upon closing mpv, the "mpv quit unexpectedly" dialogue pops up.

I am using the following flags

--hwdec=auto-safe

--vf=format=gamma=v-log:colorlevels=full:primaries=v-gamut:sig-peak=10

--target-colorspace-hint
--cocoa-cb-output-csp=bt.2100-pq
vo=gpu-next

Disabling target-colorspace-hint will prevent the "mpv quit unexpectedly" dialogue, but EDR no longer works.

output.txt
crash report.txt

from mpv.

Akemi avatar Akemi commented on June 16, 2024

yeah this has been reported already #12666.

if you are suing vo=gpu-next, cocoa-cb-output-csp is not needed. target-colorspace-hint is enough.

i am closing this one then, since the only issue now has already been reported.

from mpv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.