Coder Social home page Coder Social logo

Comments (4)

zliu41 avatar zliu41 commented on May 20, 2024

@andreasabel Thanks for catching this. I've updated the upper bounds of base for the latest several versions on Hackage. Since ghc versions map 1:1 to base versions, will remove bounds on ghc in future releases.

from apply-refact.

andreasabel avatar andreasabel commented on May 20, 2024

@zliu41 wrote:

Since ghc versions map 1:1 to base versions, will remove bounds on ghc in future releases.

Are you sure about this? Aren't there two GHCs to consider?

  • The GHC you are compiling apply-refact with (here, a bound on base can be used to restrict compilability---although I do not see why one would restrict this way).
  • The GHC library you are using (to parse, print, manipulate Haskell code). This is the ghc package, I suppose.

from apply-refact.

zliu41 avatar zliu41 commented on May 20, 2024

My understanding is that you can't depend on a different version of the GHC library than the GHC compiler version you are using. That is the whole reason why ghc-lib exists.

So there's no need to have bounds on both base and ghc. While I don't have a preference on which one to put the bounds on, almost all Hackage packages have bounds on base so I chose base.

from apply-refact.

andreasabel avatar andreasabel commented on May 20, 2024

I think because build failures (e.g., https://github.com/ndmitchell/hlint/runs/4691040973?check_suite_focus=true#step:8:286) happen due to changes in the ghc module rather than changes in base, it would make more sense to put the relevant bounds on ghc.

from apply-refact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.