Comments (4)
@andreasabel Thanks for catching this. I've updated the upper bounds of base
for the latest several versions on Hackage. Since ghc
versions map 1:1 to base
versions, will remove bounds on ghc
in future releases.
from apply-refact.
@zliu41 wrote:
Since
ghc
versions map 1:1 tobase
versions, will remove bounds onghc
in future releases.
Are you sure about this? Aren't there two GHCs to consider?
- The GHC you are compiling
apply-refact
with (here, a bound onbase
can be used to restrict compilability---although I do not see why one would restrict this way). - The GHC library you are using (to parse, print, manipulate Haskell code). This is the
ghc
package, I suppose.
from apply-refact.
My understanding is that you can't depend on a different version of the GHC library than the GHC compiler version you are using. That is the whole reason why ghc-lib
exists.
So there's no need to have bounds on both base
and ghc
. While I don't have a preference on which one to put the bounds on, almost all Hackage packages have bounds on base
so I chose base
.
from apply-refact.
I think because build failures (e.g., https://github.com/ndmitchell/hlint/runs/4691040973?check_suite_focus=true#step:8:286) happen due to changes in the ghc
module rather than changes in base
, it would make more sense to put the relevant bounds on ghc
.
from apply-refact.
Related Issues (20)
- The suggestion "Avoid lambda" does not add parenthesis around code blocks when it should HOT 1
- Comments are sometimes not placed at the right position after refactoring
- Build failure on GHC 9.0.1 on macOS HOT 3
- Remove redundant parens in class constraint removes only ending one HOT 4
- Build failure on GHC 9.2 HOT 6
- Unexpected replacement while mixed infix and parenthesis
- Refactoring of monadic code results in code that is parenthesized erroneously HOT 2
- Missing brackets when replacing flip(:)
- Fails to install on Mac M1
- Build failure on GHC 9.4 HOT 6
- Replacing return with pure unindents
- Apply-refact shouldn't hardcode `GHC.Paths.libdir` in `parseModuleWithArgs` HOT 1
- Migrate from `ghc-paths` to `hie-bios` for obtaining the libdir of ghc at run-time
- Comment is repeated. HOT 1
- Apply Hint removes shebang line at top of file
- Failure on applying refactors to cpp file
- Refactor panis when running on haskell source files
- `apply-refact` removes parens in the whole module
- cabal new-install apply-refact macos failures HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apply-refact.