Coder Social home page Coder Social logo

Move mPDF to its own namespace about mpdf HOT 13 CLOSED

mpdf avatar mpdf commented on June 17, 2024 1
Move mPDF to its own namespace

from mpdf.

Comments (13)

TomK avatar TomK commented on June 17, 2024

While we're doing this, PSR-4 compliance would be great (#37)

from mpdf.

finwe avatar finwe commented on June 17, 2024

Yes, that is exactly my intent.

from mpdf.

finwe avatar finwe commented on June 17, 2024

On second thougths, maybe classic PascalCase would be better - \Mpdf\Mpdf. Thoughts?

from mpdf.

jakejackson1 avatar jakejackson1 commented on June 17, 2024

\mPDF\mPDF\ seems easier on the eyes. That would be my vote.

from mpdf.

TomK avatar TomK commented on June 17, 2024

I'd probably go with PSR1 definition in this case \Mpdf\Mpdf
https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md

There's some things in PSR I disagree with (mainly brace position), but this isn't one of them. With lots of imports, the uniformity is pleasant.

from mpdf.

garex avatar garex commented on June 17, 2024

\Mpdf\Mpdf + 1

from mpdf.

jakejackson1 avatar jakejackson1 commented on June 17, 2024

I had the same second thoughts as @finwe. Keep the the standard: \Mpdf\Mpdf

from mpdf.

sebathi avatar sebathi commented on June 17, 2024

This is a need :D

from mpdf.

finwe avatar finwe commented on June 17, 2024

I have a working cleaned up version in namespaces branch

from mpdf.

garex avatar garex commented on June 17, 2024

What about semantic version? As this seems to break all compatibility.

One possible workaround is to have some wrapper-retranslator in root namespace, that will translate all requests to new namespaced code. And put it in standalone repo.

Or this is too complicated?

from mpdf.

finwe avatar finwe commented on June 17, 2024

All this is planned for version 7.

from mpdf.

sebathi avatar sebathi commented on June 17, 2024

Is there a roadmap for it? Thank you for this great work!

from mpdf.

finwe avatar finwe commented on June 17, 2024

No, there is no roadmap ATM, sorry.

from mpdf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.