Coder Social home page Coder Social logo

Comments (6)

0xdiba avatar 0xdiba commented on July 29, 2024

I totally agree with both.
Probably the same thing must be done to the issuer column.

Should we make these fields jsonb fields for consistency or
go with different fields for all of them ? ( subject_cn, subject_o etc... )

from tls-observatory.

jvehent avatar jvehent commented on July 29, 2024

A different column for each seems overkill, but better in line with how databases are supposed to work.
jsonb would allow us to query inside without require multiple columns, I like that options (select subject->>'CN').
Or we can just store the string: C=US, ST=California, L=Mountain View, O=Google Inc, CN=*.google.com

Whichever you think is best.

from tls-observatory.

jvehent avatar jvehent commented on July 29, 2024

Another side effect of the current code is that a number of CA certs don't have a CN, and their subject columns are empty in the database. For example:

observatory=> select count(id) from certificates where is_ca='t' and subject='';
 count 
-------
    68

from tls-observatory.

0xdiba avatar 0xdiba commented on July 29, 2024

Yes a lot of CAs have an empty CN.
This will be solved by transforming the subject and issuer columns to type jsonb and storing all the fields that identify the subject or issuer ( CN, C , O ...).

from tls-observatory.

0xdiba avatar 0xdiba commented on July 29, 2024

Isn't this solved with the merging of #77 ?

from tls-observatory.

jvehent avatar jvehent commented on July 29, 2024

Yep. 👍

from tls-observatory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.